Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 12:52:47PM +0100, Ingo Molnar escreveu: > > * Adrian Hunter wrote: > > > On 27/11/13 13:32, Ingo Molnar wrote: > > > > > > * Adrian Hunter wrote: > > > > > >> On 26/11/13 18:15, Ingo Molnar wrote: > > >>> > > >>> * Adrian Hunter wrote: > > >>> > > The logic was n

Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-27 Thread Ingo Molnar
* Adrian Hunter wrote: > On 27/11/13 13:32, Ingo Molnar wrote: > > > > * Adrian Hunter wrote: > > > >> On 26/11/13 18:15, Ingo Molnar wrote: > >>> > >>> * Adrian Hunter wrote: > >>> > The logic was not looking in the buildid cache for kcore > if the host kernel buildid did not matc

Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-27 Thread Adrian Hunter
On 27/11/13 13:32, Ingo Molnar wrote: > > * Adrian Hunter wrote: > >> On 26/11/13 18:15, Ingo Molnar wrote: >>> >>> * Adrian Hunter wrote: >>> The logic was not looking in the buildid cache for kcore if the host kernel buildid did not match the recorded kernel buildid. >>> >>> It

Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-27 Thread Ingo Molnar
* Adrian Hunter wrote: > On 26/11/13 18:15, Ingo Molnar wrote: > > > > * Adrian Hunter wrote: > > > >> The logic was not looking in the buildid cache for kcore > >> if the host kernel buildid did not match the recorded > >> kernel buildid. > > > > It would be nice to also include the specifi

Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-27 Thread Adrian Hunter
On 26/11/13 18:15, Ingo Molnar wrote: > > * Adrian Hunter wrote: > >> The logic was not looking in the buildid cache for kcore >> if the host kernel buildid did not match the recorded >> kernel buildid. > > It would be nice to also include the specific failure mode in the > changelog: exactly

Re: [PATCH] perf tools: Fix not finding kcore in buildid cache

2013-11-26 Thread Ingo Molnar
* Adrian Hunter wrote: > The logic was not looking in the buildid cache for kcore > if the host kernel buildid did not match the recorded > kernel buildid. It would be nice to also include the specific failure mode in the changelog: exactly how can users run into this. That will be more usefu