Re: [PATCH] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL

2019-05-29 Thread David Rientjes
On Tue, 28 May 2019, Christoph Hellwig wrote: > > wd719x_chip_init is getting called in interrupt disabled > > mode(spin_lock_irqsave) , so we need to GFP_ATOMIC instead > > of GFP_KERNEL. > > > > Issue identified by coccicheck > > I don't think request_firmware is any more happy being called un

Re: [PATCH] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL

2019-05-28 Thread Christoph Hellwig
On Wed, May 29, 2019 at 07:05:40AM +0530, Hariprasad Kelam wrote: > wd719x_chip_init is getting called in interrupt disabled > mode(spin_lock_irqsave) , so we need to GFP_ATOMIC instead > of GFP_KERNEL. > > Issue identified by coccicheck I don't think request_firmware is any more happy being call