Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Ingo Molnar
* Tao Guo wrote: > On Wed, Sep 26, 2012 at 9:25 PM, Greg KH wrote: > > On Wed, Sep 26, 2012 at 04:28:22AM -0400, Tao Guo wrote: > >> gas in binutils(2.16.91) could not parse parentheses within macro > >> parameters unless fully parenthesized, and this is a workaround to > >> make old gas work w

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Tao Guo
On Wed, Sep 26, 2012 at 9:25 PM, Greg KH wrote: > On Wed, Sep 26, 2012 at 04:28:22AM -0400, Tao Guo wrote: >> gas in binutils(2.16.91) could not parse parentheses within macro >> parameters unless fully parenthesized, and this is a workaround to >> make old gas work without generating below errors

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Greg KH
On Wed, Sep 26, 2012 at 04:28:22AM -0400, Tao Guo wrote: > gas in binutils(2.16.91) could not parse parentheses within macro > parameters unless fully parenthesized, and this is a workaround to > make old gas work without generating below errors: > arch/x86/kernel/entry_64.S: Assembler messages: >

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Jan Beulich
>>> On 26.09.12 at 13:16, Ingo Molnar wrote: > * Jan Beulich wrote: > >> >>> On 26.09.12 at 10:28, Tao Guo wrote: >> > gas in binutils(2.16.91) could not parse parentheses within macro >> > parameters unless fully parenthesized, and this is a workaround to >> > make old gas work without genera

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 26.09.12 at 10:28, Tao Guo wrote: > > gas in binutils(2.16.91) could not parse parentheses within macro > > parameters unless fully parenthesized, and this is a workaround to > > make old gas work without generating below errors: > > arch/x86/kernel/entry_64.S: Ass

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Jan Beulich
>>> On 26.09.12 at 10:28, Tao Guo wrote: > gas in binutils(2.16.91) could not parse parentheses within macro > parameters unless fully parenthesized, and this is a workaround to > make old gas work without generating below errors: > arch/x86/kernel/entry_64.S: Assembler messages: > arch/x86/kernel

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Tao Guo
On 9/26/12, Jan Beulich wrote: On 26.09.12 at 08:15, Tao Guo wrote: >> gas in binutils(2.16.91) could not parse parentheses within macro >> parameters, > > This description of yours contradicts the last hunk of the patch - > iirc the requirement for macro parameters in those old gas > versio

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Jan Beulich
>>> On 26.09.12 at 08:15, Tao Guo wrote: > gas in binutils(2.16.91) could not parse parentheses within macro > parameters, This description of yours contradicts the last hunk of the patch - iirc the requirement for macro parameters in those old gas versions is to be fully parenthesized if there's