Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-24 Thread Peter Hurley
On 09/22/2013 04:03 PM, Oleg Nesterov wrote: On 09/21, Peter Hurley wrote: On 09/21/2013 02:34 PM, Oleg Nesterov wrote: do_each_pid_task(tty->session, PIDTYPE_SID, p) { spin_lock_irq(&p->sighand->siglock); if (p->signal->tty == t

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-22 Thread Oleg Nesterov
On 09/21, Peter Hurley wrote: > > On 09/21/2013 02:34 PM, Oleg Nesterov wrote: >> >> do_each_pid_task(tty->session, PIDTYPE_SID, p) { >> spin_lock_irq(&p->sighand->siglock); >> if (p->signal->tty == tty) { >> p->sig

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-21 Thread Peter Hurley
On 09/21/2013 02:34 PM, Oleg Nesterov wrote: Peter, sorry for delay, I was sick. On 09/17, Peter Hurley wrote: On 09/15/2013 11:50 AM, Oleg Nesterov wrote: Put the "!on_exit" check back to restore the old behaviour. Cc: sta...@vger.kernel.org # v3.10+ Signed-off-by: Oleg Nesterov Reported-

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-21 Thread Oleg Nesterov
Peter, sorry for delay, I was sick. On 09/17, Peter Hurley wrote: > > On 09/15/2013 11:50 AM, Oleg Nesterov wrote: > >> Put the "!on_exit" check back to restore the old behaviour. >> >> Cc: sta...@vger.kernel.org # v3.10+ >> Signed-off-by: Oleg Nesterov >> Reported-by: Karel Srot > > Reviewed-by

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-17 Thread Peter Hurley
On 09/15/2013 11:50 AM, Oleg Nesterov wrote: Starting from v3.10 (probably f91e2590 "tty: Signal foreground group processes in hangup") disassociate_ctty() sends SIGCONT if tty && on_exit. This breaks LSB test-suite, in particular test8 in _exit.c and test40 in sigcon5.c. Yes, this regression w

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-17 Thread Peter Hurley
On 09/17/2013 03:41 PM, Carlos O'Donell wrote: On 09/16/2013 06:16 PM, Peter Hurley wrote: On 09/15/2013 11:50 AM, Oleg Nesterov wrote: Starting from v3.10 (probably f91e2590 "tty: Signal foreground group processes in hangup") disassociate_ctty() sends SIGCONT if tty && on_exit. This breaks LSB

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-17 Thread Carlos O'Donell
On 09/16/2013 06:16 PM, Peter Hurley wrote: > On 09/15/2013 11:50 AM, Oleg Nesterov wrote: >> Starting from v3.10 (probably f91e2590 "tty: Signal foreground >> group processes in hangup") disassociate_ctty() sends SIGCONT >> if tty && on_exit. This breaks LSB test-suite, in particular >> test8 in _

Re: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT

2013-09-16 Thread Peter Hurley
On 09/15/2013 11:50 AM, Oleg Nesterov wrote: Starting from v3.10 (probably f91e2590 "tty: Signal foreground group processes in hangup") disassociate_ctty() sends SIGCONT if tty && on_exit. This breaks LSB test-suite, in particular test8 in _exit.c and test40 in sigcon5.c. Put the "!on_exit" chec