Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

2013-09-02 Thread Samuel Ortiz
Hi Chao, On Mon, Sep 02, 2013 at 09:21:04AM +0800, Chao Xie wrote: > On Fri, Aug 30, 2013 at 8:30 PM, Samuel Ortiz wrote: > > Hi Xie, > > > > On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: > >> On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz > >> wrote: > >> > Hi Xie, > >> > > >> > On

Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

2013-09-01 Thread Chao Xie
On Fri, Aug 30, 2013 at 8:30 PM, Samuel Ortiz wrote: > Hi Xie, > > On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: >> On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz wrote: >> > Hi Xie, >> > >> > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: >> >> User pass platform data to de

Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

2013-08-30 Thread Samuel Ortiz
Hi Xie, On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: > On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz wrote: > > Hi Xie, > > > > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: > >> User pass platform data to device, and platform data may be > >> NULL. > > In which case do y

Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

2013-08-26 Thread Chao Xie
On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz wrote: > Hi Xie, > > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: >> User pass platform data to device, and platform data may be >> NULL. > In which case do you get that ? With DT ? > Should rtc_init fail when pdata is NULL ? > > You need

Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL

2013-08-19 Thread Samuel Ortiz
Hi Xie, On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: > User pass platform data to device, and platform data may be > NULL. In which case do you get that ? With DT ? Should rtc_init fail when pdata is NULL ? You need to explain that, be it only for us to know if it's a critical fix