Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:44 PM, Josh Wu wrote: On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri,

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Ale

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Nicolas Ferre
Le 20/07/2015 10:35, Josh Wu a écrit : > Hi, Maxime > > On 7/20/2015 3:52 PM, Maxime Ripard wrote: >> Hi Josh, >> >> On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: >>> On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : > On Fri, Jul 10, 2015

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07/2

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Maxime Ripard
Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: > On 7/11/2015 12:12 AM, Nicolas Ferre wrote: > >Le 10/07/2015 14:31, Maxime Ripard a écrit : > >>On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: > >>>Hi, > >>> > >>>On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-12 Thread Josh Wu
On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : I would agree with Maxime. Currently all latest chip reset function is compatible wi

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Guenter
On Fri, Jul 10, 2015 at 07:56:58AM +0200, Alexandre Belloni wrote: > Hi Guenter, > > On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote : > > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for > > > the > > > reset driver of sama5d3 and later chips. > > > As in sama5d3 or

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Nicolas Ferre
Le 10/07/2015 14:31, Maxime Ripard a écrit : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: >> Hi, >> >> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : >>> I would agree with Maxime. Currently all latest chip reset function is >>> compatible with the atmel,sama5d3-rstc. >>>

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Alexandre Belloni
On 10/07/2015 at 14:31:48 +0200, Maxime Ripard wrote : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : > > > I would agree with Maxime. Currently all latest chip reset function is > > > compatible with the atmel,

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Maxime Ripard
On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: > Hi, > > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : > > I would agree with Maxime. Currently all latest chip reset function is > > compatible with the atmel,sama5d3-rstc. > > So check compatible string is enough for now. > >

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Alexandre Belloni
Hi, On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : > I would agree with Maxime. Currently all latest chip reset function is > compatible with the atmel,sama5d3-rstc. > So check compatible string is enough for now. > But of cause if we have other incompatible reset in future with new chip, > the

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
On 7/10/2015 2:54 PM, Maxime Ripard wrote: On Fri, Jul 10, 2015 at 11:06:52AM +0800, Josh Wu wrote: Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr control

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
Hi, Alexandre On 7/10/2015 2:03 PM, Alexandre Belloni wrote: Hi, On 09/07/2015 at 18:15:46 +0800, Josh Wu wrote : As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Maxime Ripard
On Fri, Jul 10, 2015 at 08:03:50AM +0200, Alexandre Belloni wrote: > > static const struct of_device_id at91_reset_of_match[] = { > > { .compatible = "atmel,at91sam9260-rstc", .data = at91sam9260_restart }, > > { .compatible = "atmel,at91sam9g45-rstc", .data = at91sam9g45_restart }, > > +

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Maxime Ripard
On Fri, Jul 10, 2015 at 11:06:52AM +0800, Josh Wu wrote: > Hi, Maxime > > On 7/9/2015 8:03 PM, Maxime Ripard wrote: > >Hi, > > > >On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: > >>As since sama5d3, to reset the chip, we don't need to shutdown the ddr > >>controller. > >> > >>So add a ne

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Alexandre Belloni
Hi, On 09/07/2015 at 18:15:46 +0800, Josh Wu wrote : > As since sama5d3, to reset the chip, we don't need to shutdown the ddr > controller. > > So add a new compatible string and new restart function for sama5d3 and > later chips. As we don't use sama5d3 ddr controller, so remove it as > well. >

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Alexandre Belloni
Hi Guenter, On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote : > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the > > reset driver of sama5d3 and later chips. > > As in sama5d3 or later chips, we don't have to shutdown the DDR controller > > before reset. Shutdown

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 11:14 AM, Guenter Roeck wrote: On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote: Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Guenter Roeck
On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote: > Hi, Guenter > > On 7/10/2015 1:37 AM, Guenter Roeck wrote: > >On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: > >>As since sama5d3, to reset the chip, we don't need to shutdown the ddr > >>controller. > >> > >>So add a new compati

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't us

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Guenter Roeck
On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: > As since sama5d3, to reset the chip, we don't need to shutdown the ddr > controller. > > So add a new compatible string and new restart function for sama5d3 and > later chips. As we don't use sama5d3 ddr controller, so remove it as > well.

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Nicolas Ferre
Le 09/07/2015 14:03, Maxime Ripard a écrit : > Hi, > > On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: >> As since sama5d3, to reset the chip, we don't need to shutdown the ddr >> controller. >> >> So add a new compatible string and new restart function for sama5d3 and >> later chips. As

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Maxime Ripard
Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: > As since sama5d3, to reset the chip, we don't need to shutdown the ddr > controller. > > So add a new compatible string and new restart function for sama5d3 and > later chips. As we don't use sama5d3 ddr controller, so remove it as >