Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-28 Thread Stephen Hemminger
On Mon, 28 Oct 2013 00:38:07 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Fri, 25 Oct 2013 08:41:34 -0700 > > > I would rather not fix the warning this way since it risks masking > > later bugs if this code ever changes. > > But this is suboptimally coded, and is asking fo

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-27 Thread David Miller
From: Stephen Hemminger Date: Fri, 25 Oct 2013 08:41:34 -0700 > I would rather not fix the warning this way since it risks masking > later bugs if this code ever changes. But this is suboptimally coded, and is asking for the warning. Anything returning a pointer by reference is asking for troub

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-27 Thread Stephen Hemminger
On Sun, 27 Oct 2013 10:30:56 +0800 Zhi Yong Wu wrote: > HI, Stephen > > I saw it on Fedora 17 without latest kernel. Then what do you think > that it is appropriate to solve this problem? discard this patch? If > yes, i can also agree. > Either find where the uninitialized use is being caused

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
HI, Stephen I saw it on Fedora 17 without latest kernel. Then what do you think that it is appropriate to solve this problem? discard this patch? If yes, i can also agree. On Sat, Oct 26, 2013 at 10:48 PM, Stephen Hemminger wrote: > On Sat, 26 Oct 2013 15:06:04 +0800 > Zhi Yong Wu wrote: > >>

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Stephen Hemminger
On Sat, 26 Oct 2013 15:06:04 +0800 Zhi Yong Wu wrote: > On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger > wrote: > > On Fri, 25 Oct 2013 15:49:18 +0800 > > Zhi Yong Wu wrote: > > > >> From: Zhi Yong Wu > >> > >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’: > >> drivers/net/vxlan.c:22

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger wrote: > On Fri, 25 Oct 2013 15:49:18 +0800 > Zhi Yong Wu wrote: > >> From: Zhi Yong Wu >> >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’: >> drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in >> this function [-Wm

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-25 Thread Stephen Hemminger
On Fri, 25 Oct 2013 15:49:18 +0800 Zhi Yong Wu wrote: > From: Zhi Yong Wu > > drivers/net/vxlan.c: In function ‘vxlan_sock_add’: > drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > drivers/net/vxlan.c:2275:17: note: ‘sock’ was d