Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-07 Thread Dave Hansen
Hi Roman, How does the attached patch look? It will still give us the flexibility to override the memory models, but only in the presence of CONFIG_EXPERIMENTAL. It also adds some better help text to the DISCONTIGMEM menu. Is that something like what you were looking for? -- Dave --- memh

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-07 Thread Dave Hansen
On Thu, 2005-04-07 at 02:30 +0200, Roman Zippel wrote: > I was hoping for this too, in the meantime can't you simply make it a > suboption of DISCONTIGMEM? So an extra option is only visible when it's > enabled and most people can ignore it completely by just disabling a > single option. That's

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-06 Thread Roman Zippel
Hi, On Wed, 6 Apr 2005, Dave Hansen wrote: > > Why is this choice needed at all? Why would one choose SPARSEMEM over > > DISCONTIGMEM? > > For now, it's only so people can test either one, and we don't have to > try to toss DICONTIGMEM out of the kernel in fell swoop. When the > memory hotplug

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-06 Thread Dave Hansen
On Thu, 2005-04-07 at 01:40 +0200, Roman Zippel wrote: > On Wed, 6 Apr 2005, Dave Hansen wrote: > > On Wed, 2005-04-06 at 22:58 +0200, Roman Zippel wrote: > > > Dave Hansen wrote: > > > > --- memhotplug/mm/Kconfig~A6-mm-Kconfig 2005-04-04 09:04:48.0 > > > > -0700 > > > > +++ memhotplug-dav

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-06 Thread Roman Zippel
Hi, On Wed, 6 Apr 2005, Dave Hansen wrote: > On Wed, 2005-04-06 at 22:58 +0200, Roman Zippel wrote: > > Dave Hansen wrote: > > > --- memhotplug/mm/Kconfig~A6-mm-Kconfig 2005-04-04 09:04:48.0 > > > -0700 > > > +++ memhotplug-dave/mm/Kconfig2005-04-04 10:15:23.0 -0700 > > > @

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-06 Thread Dave Hansen
On Wed, 2005-04-06 at 22:58 +0200, Roman Zippel wrote: > Dave Hansen wrote: > > --- memhotplug/mm/Kconfig~A6-mm-Kconfig 2005-04-04 09:04:48.0 > > -0700 > > +++ memhotplug-dave/mm/Kconfig 2005-04-04 10:15:23.0 -0700 > > @@ -0,0 +1,25 @@ > > +choice > > + prompt "Memory mo

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-06 Thread Roman Zippel
Hi, Dave Hansen wrote: > diff -puN mm/Kconfig~A6-mm-Kconfig mm/Kconfig > --- memhotplug/mm/Kconfig~A6-mm-Kconfig 2005-04-04 09:04:48.0 > -0700 > +++ memhotplug-dave/mm/Kconfig2005-04-04 10:15:23.0 -0700 > @@ -0,0 +1,25 @@ > +choice > + prompt "Memory model" > +

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-04 Thread Mike Kravetz
On Mon, Apr 04, 2005 at 10:50:09AM -0700, Dave Hansen wrote: diff -puN mm/Kconfig~A6-mm-Kconfig mm/Kconfig --- memhotplug/mm/Kconfig~A6-mm-Kconfig 2005-04-04 09:04:48.0 -0700 +++ memhotplug-dave/mm/Kconfig 2005-04-04 10:15:23.0 -0700 @@ -0,0 +1,25 @@ > +choice > + prompt "Memor

Re: [PATCH 1/4] create mm/Kconfig for arch-independent memory options

2005-04-04 Thread Dave Hansen
On Mon, 2005-04-04 at 16:22 -0700, Mike Kravetz wrote: > Do you need to set ARCH_DISCONTIGMEM_DEFAULT instead of just > CONFIG_ARCH_DISCONTIGMEM_ENABLE to have DISCONTIGMEM be the > default? or am I missing something? I don't see > ARCH_DISCONTIGMEM_DEFAULT turned on by default in any of these > p