Re: [PATCH 1/4] perf evsel: Add evsel__clone() function

2020-09-20 Thread Namhyung Kim
Hi Jiri, On Fri, Sep 18, 2020 at 10:31 PM Jiri Olsa wrote: > > On Wed, Sep 16, 2020 at 03:31:26PM +0900, Namhyung Kim wrote: > > SNIP > > > +struct evsel *evsel__clone(struct evsel *orig) > > +{ > > + struct evsel *evsel; > > + struct evsel_config_term *pos, *tmp; > > + > > + BUG_ON(o

Re: [PATCH 1/4] perf evsel: Add evsel__clone() function

2020-09-18 Thread Jiri Olsa
On Wed, Sep 16, 2020 at 03:31:26PM +0900, Namhyung Kim wrote: SNIP > +struct evsel *evsel__clone(struct evsel *orig) > +{ > + struct evsel *evsel; > + struct evsel_config_term *pos, *tmp; > + > + BUG_ON(orig->core.fd); > + BUG_ON(orig->counts); > + BUG_ON(orig->priv); > +

Re: [PATCH 1/4] perf evsel: Add evsel__clone() function

2020-09-10 Thread Namhyung Kim
Hi Jiri, On Thu, Sep 10, 2020 at 5:59 PM Jiri Olsa wrote: > > On Tue, Sep 08, 2020 at 01:42:25PM +0900, Namhyung Kim wrote: > > The evsel__clone() is to create an exactly same evsel from same > > attributes. Note that metric events will be handled by later patch. > > > > It will be used by perf

Re: [PATCH 1/4] perf evsel: Add evsel__clone() function

2020-09-10 Thread Jiri Olsa
On Tue, Sep 08, 2020 at 01:42:25PM +0900, Namhyung Kim wrote: > The evsel__clone() is to create an exactly same evsel from same > attributes. Note that metric events will be handled by later patch. > > It will be used by perf stat to generate separate events for each > cgroup. > > Signed-off-by: