Re: [PATCH 1/4] staging: et131x: clean up code

2013-11-19 Thread ZHAO Gang
On Wed, Nov 20, 2013 at 1:41 PM, Greg Kroah-Hartman wrote: > In the future, you need to tell me to drop the old ones from my queue. > Normally you can do that by replying to them saying to remove them, or > put a "v2" for "version 2" on this series. > > Anyway, as Mark told you to redo them a bit,

Re: [PATCH 1/4] staging: et131x: clean up code

2013-11-19 Thread Greg Kroah-Hartman
On Wed, Nov 20, 2013 at 09:53:36AM +0800, ZHAO Gang wrote: > > I'm a bit confused - these patches apply to the current head of > > staging-next, but not on top of your previous two patches. I assume that > > you're aiming to have these changes on top of your last two, so can you > > please re-spin

Re: [PATCH 1/4] staging: et131x: clean up code

2013-11-19 Thread ZHAO Gang
> Hi, please revert the previous two patches if you can. I mean drop/ignore previous two patches, just apply this 4 patches to staging-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/4] staging: et131x: clean up code

2013-11-19 Thread ZHAO Gang
> I'm a bit confused - these patches apply to the current head of > staging-next, but not on top of your previous two patches. I assume that > you're aiming to have these changes on top of your last two, so can you > please re-spin them to apply cleanly to the head of (staging-next + your > previou

Re: [PATCH 1/4] staging: et131x: clean up code

2013-11-18 Thread Mark Einon
On Fri, Nov 15, 2013 at 08:27:58PM +0800, ZHAO Gang wrote: > 1. change function name: et1310_phy_power_down -> et1310_phy_power_switch > change function name to better describe its functionality. > > 2. as TODO file suggested, do this sort of things to reduce split lines > struct fbr_lookup *fbr; >