Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:26 +, Ben Hutchings wrote: > I don't think so. This doesn't find anything: > git grep '&[ (]*pci_resource_start' > and I was able to build drivers/{net,pci,scsi}/ successfully with > pci_resource_start() changed to an inline function. Hi again Ben. You're right.

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Ben Hutchings
On Sun, 2013-10-27 at 15:14 -0700, Joe Perches wrote: > On Sun, 2013-10-27 at 22:02 +, Ben Hutchings wrote: > > On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: > > > On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > > > > Physical addresses may be wider than virtual addresses (e.g

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:02 +, Ben Hutchings wrote: > On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: > > On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > > > Physical addresses may be wider than virtual addresses (e.g. on i386 > > > with PAE) and must not be formatted with %p. >

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Ben Hutchings
On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: > On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > > Physical addresses may be wider than virtual addresses (e.g. on i386 > > with PAE) and must not be formatted with %p. > > %pa works. %pa also prefixes with 0x. Only as long as pci_

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > Physical addresses may be wider than virtual addresses (e.g. on i386 > with PAE) and must not be formatted with %p. %pa works. %pa also prefixes with 0x. > diff --git a/drivers/infiniband/hw/cxgb4/device.c > b/drivers/infiniband/hw/cxgb4