Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-04-03 Thread Peter Zijlstra
On Tue, Apr 03, 2018 at 07:52:25AM +0200, Martin Schwidefsky wrote: > On Thu, 29 Mar 2018 20:08:36 +0200 > Peter Zijlstra wrote: > > > On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > > > The lowcore optimization for softirq_pending field is not really needed, > > > just nice

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-04-02 Thread Martin Schwidefsky
On Thu, 29 Mar 2018 20:08:36 +0200 Peter Zijlstra wrote: > On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > > The lowcore optimization for softirq_pending field is not really needed, > > just nice to have. But if there is a strong reason to make a common > > definition for it

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Peter Zijlstra
On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > The lowcore optimization for softirq_pending field is not really needed, > just nice to have. But if there is a strong reason to make a common > definition for it we can certainly do that. A slightly related question; would it m

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Frederic Weisbecker
On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > On Thu, 29 Mar 2018 16:07:49 +0200 > Frederic Weisbecker wrote: > > > On Thu, Mar 29, 2018 at 04:01:11PM +0200, Peter Zijlstra wrote: > > > On Thu, Mar 29, 2018 at 03:47:46PM +0200, Frederic Weisbecker wrote: > > > > On Thu,

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Martin Schwidefsky
On Thu, 29 Mar 2018 16:07:49 +0200 Frederic Weisbecker wrote: > On Thu, Mar 29, 2018 at 04:01:11PM +0200, Peter Zijlstra wrote: > > On Thu, Mar 29, 2018 at 03:47:46PM +0200, Frederic Weisbecker wrote: > > > On Thu, Mar 29, 2018 at 09:16:19AM +0200, Peter Zijlstra wrote: > > > > On Thu, Mar 29

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Frederic Weisbecker
On Thu, Mar 29, 2018 at 04:01:11PM +0200, Peter Zijlstra wrote: > On Thu, Mar 29, 2018 at 03:47:46PM +0200, Frederic Weisbecker wrote: > > On Thu, Mar 29, 2018 at 09:16:19AM +0200, Peter Zijlstra wrote: > > > On Thu, Mar 29, 2018 at 04:27:05AM +0200, Frederic Weisbecker wrote: > > > > The last user

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Peter Zijlstra
On Thu, Mar 29, 2018 at 03:47:46PM +0200, Frederic Weisbecker wrote: > On Thu, Mar 29, 2018 at 09:16:19AM +0200, Peter Zijlstra wrote: > > On Thu, Mar 29, 2018 at 04:27:05AM +0200, Frederic Weisbecker wrote: > > > The last user of __ARCH_SET_SOFTIRQ_PENDING has been converted to generic > > > per-c

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Frederic Weisbecker
On Thu, Mar 29, 2018 at 09:16:19AM +0200, Peter Zijlstra wrote: > On Thu, Mar 29, 2018 at 04:27:05AM +0200, Frederic Weisbecker wrote: > > The last user of __ARCH_SET_SOFTIRQ_PENDING has been converted to generic > > per-cpu softirq mask. We can now remove this conditional. > > This seems like hal

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Peter Zijlstra
On Thu, Mar 29, 2018 at 04:27:05AM +0200, Frederic Weisbecker wrote: > The last user of __ARCH_SET_SOFTIRQ_PENDING has been converted to generic > per-cpu softirq mask. We can now remove this conditional. This seems like half a cleanup; who still has local_softirq_pending() after this? > > #el