Re: [PATCH 2/20] x86_64: Assembly safe page.h and pgtable.h

2006-11-18 Thread Vivek Goyal
On Sat, Nov 18, 2006 at 09:49:14AM +0100, Andi Kleen wrote: > On Friday 17 November 2006 23:37, Vivek Goyal wrote: > > > > This patch makes pgtable.h and page.h safe to include > > in assembly files like head.S. Allowing us to use > > symbolic constants instead of hard coded numbers when > > refer

Re: [PATCH 2/20] x86_64: Assembly safe page.h and pgtable.h

2006-11-18 Thread Andi Kleen
On Friday 17 November 2006 23:37, Vivek Goyal wrote: > > This patch makes pgtable.h and page.h safe to include > in assembly files like head.S. Allowing us to use > symbolic constants instead of hard coded numbers when > refering to the page tables. I still think that macro is horrible ugly and