Re: [PATCH 2/3] random: Return nbytes filled from hw RNG

2018-05-01 Thread Tobin C. Harding
On Tue, May 01, 2018 at 09:39:02PM -0400, Steven Rostedt wrote: > On Wed, 2 May 2018 09:33:39 +1000 > "Tobin C. Harding" wrote: > > > diff --git a/drivers/char/random.c b/drivers/char/random.c > > index 031d18b31e0f..3a66507ea60b 100644 > > --- a/drivers/char/random.c > > +++ b/drivers/char/rand

Re: [PATCH 2/3] random: Return nbytes filled from hw RNG

2018-05-01 Thread Steven Rostedt
On Wed, 2 May 2018 09:33:39 +1000 "Tobin C. Harding" wrote: > diff --git a/drivers/char/random.c b/drivers/char/random.c > index 031d18b31e0f..3a66507ea60b 100644 > --- a/drivers/char/random.c > +++ b/drivers/char/random.c > @@ -1725,26 +1725,28 @@ EXPORT_SYMBOL(del_random_ready_callback); > *

Re: [PATCH 2/3] random: Return nbytes filled from hw RNG

2018-05-01 Thread Theodore Y. Ts'o
On Wed, May 02, 2018 at 09:33:39AM +1000, Tobin C. Harding wrote: > Currently the function get_random_bytes_arch() has return value 'void'. > If the hw RNG fails we currently fall back to using get_random_bytes(). > This defeats the purpose of requesting random material from the hw RNG > in the fir

Re: [PATCH 2/3] random: Return nbytes filled from hw RNG

2018-05-01 Thread Tobin C. Harding
On Wed, May 02, 2018 at 09:33:39AM +1000, Tobin C. Harding wrote: > Currently the function get_random_bytes_arch() has return value 'void'. > If the hw RNG fails we currently fall back to using get_random_bytes(). > This defeats the purpose of requesting random material from the hw RNG > in the fir