Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-02 Thread David Brownell
On Wednesday 02 January 2008, Alan Stern wrote: >  BTW, I don't recall ever seeing Tony's patch announced on > linux-usb or linux-usb-devel.  Did I simply miss it? I think he didn't post it. I got some questions from him at one point, which I answered, but as I recall he decided for some re

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-02 Thread Alan Stern
On Tue, 1 Jan 2008, Greg KH wrote: > On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: > > On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > > > On Sun, 30 Dec 2007, Greg KH wrote: > > > > > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > > >

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Greg KH
On Wed, Jan 02, 2008 at 07:13:08AM +0100, Andreas Mohr wrote: > Hi, > > On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: > > Ok, no, I didn't write that patch, I'm getting very confused here. > > > > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. > > > > In the -mm tree t

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Andreas Mohr
Hi, On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: > Ok, no, I didn't write that patch, I'm getting very confused here. > > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. > > In the -mm tree there is a patch, from Tony Jones, that moves some debug > code out of sysfs an

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Andreas Mohr
Hi, On Sun, Dec 30, 2007 at 03:34:45PM -0500, Alan Stern wrote: > It looks like Greg misused the debugfs API -- which is ironic, because > he wrote debugfs in the first place! :-) > > Let me know if this patch fixes the problem. If it does, I'll submit > it to Greg with all the proper accoutre

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Greg KH
On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: > On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > > On Sun, 30 Dec 2007, Greg KH wrote: > > > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > > he wrote debugfs in the first place! :-) > > >

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-31 Thread Greg KH
On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > On Sun, 30 Dec 2007, Greg KH wrote: > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > he wrote debugfs in the first place! :-) > > > > Oh crap, sorry, I did mess that up :( > > > > > Let me know if

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-31 Thread Alan Stern
On Sun, 30 Dec 2007, Greg KH wrote: > > It looks like Greg misused the debugfs API -- which is ironic, because > > he wrote debugfs in the first place! :-) > > Oh crap, sorry, I did mess that up :( > > > Let me know if this patch fixes the problem. If it does, I'll submit > > it to Greg with

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-30 Thread Greg KH
On Sun, Dec 30, 2007 at 03:34:45PM -0500, Alan Stern wrote: > On Sun, 30 Dec 2007, Ingo Molnar wrote: > > > * Andreas Mohr <[EMAIL PROTECTED]> wrote: > > > > > (yes, that's all there is, despite CONFIG_USB_DEBUG being set) > > > > > > The LED of a usb stick isn't active either, for obvious reaso

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-30 Thread Alan Stern
On Sun, 30 Dec 2007, Ingo Molnar wrote: > * Andreas Mohr <[EMAIL PROTECTED]> wrote: > > > (yes, that's all there is, despite CONFIG_USB_DEBUG being set) > > > > The LED of a usb stick isn't active either, for obvious reasons. > > > > And keep in mind that this is a (relatively old) OHCI-only ma

[usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-30 Thread Ingo Molnar
* Andreas Mohr <[EMAIL PROTECTED]> wrote: > (yes, that's all there is, despite CONFIG_USB_DEBUG being set) > > The LED of a usb stick isn't active either, for obvious reasons. > > And keep in mind that this is a (relatively old) OHCI-only machine... > (which had the 2.6.19 lsmod showing ohci-h

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
Hi, On Fri, Dec 28, 2007 at 09:22:01AM +0300, Alexey Dobriyan wrote: > On Thu, Dec 27, 2007 at 11:17:28PM +0100, Andreas Mohr wrote: > > And this is the state that my 2.6.24-rc_six_-mm1 tree is in already. > > OK. > > > So either it didn't help here or it broke again by some later change or > >

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Alexey Dobriyan
On Thu, Dec 27, 2007 at 11:17:28PM +0100, Andreas Mohr wrote: > Hi, > > On Thu, Dec 27, 2007 at 09:41:45PM +0300, Alexey Dobriyan wrote: > > On Thu, Dec 27, 2007 at 06:40:56PM +0100, Andreas Mohr wrote: > > > On Fri, Dec 07, 2007 at 02:23:42AM -0800, Andrew Morton wrote: > > > > > (commit 2b1e300a

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
Hi, On Thu, Dec 27, 2007 at 09:41:45PM +0300, Alexey Dobriyan wrote: > On Thu, Dec 27, 2007 at 06:40:56PM +0100, Andreas Mohr wrote: > > On Fri, Dec 07, 2007 at 02:23:42AM -0800, Andrew Morton wrote: > > > > (commit 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416) > > > > > > > > This seems to have brok

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Alexey Dobriyan
On Thu, Dec 27, 2007 at 06:40:56PM +0100, Andreas Mohr wrote: > On Fri, Dec 07, 2007 at 02:23:42AM -0800, Andrew Morton wrote: > > > (commit 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416) > > > > > > This seems to have broken the use of /proc/bus/usb as a mountpoint. It > > > always appears empty now,

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
Hi, On Fri, Dec 07, 2007 at 02:23:42AM -0800, Andrew Morton wrote: > > (commit 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416) > > > > This seems to have broken the use of /proc/bus/usb as a mountpoint. It > > always appears empty now, whatever's supposed to be mounted there. > > > > Yes. Denis and

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-07 Thread Denis V. Lunev
Andrew Morton wrote: > On Fri, 07 Dec 2007 04:51:37 + David Woodhouse <[EMAIL PROTECTED]> wrote: > >> On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: >>> Well I clearly goofed when I added the initial network namespace support >>> for /proc/net. Currently things work but there are

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-07 Thread Andrew Morton
On Fri, 07 Dec 2007 04:51:37 + David Woodhouse <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: > > Well I clearly goofed when I added the initial network namespace support > > for /proc/net. Currently things work but there are odd details visible > > t

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-06 Thread David Woodhouse
On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: > Well I clearly goofed when I added the initial network namespace support > for /proc/net. Currently things work but there are odd details visible > to user space, even when we have a single network namespace. > > Since we do not cache

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-11-27 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > [snip] > >> >> Well I clearly goofed when I added the initial network namespace support >> for /proc/net. Currently things work but there are odd details visible >> to user space, even when we have a single network namespace. >> >> Since we do not c

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-11-27 Thread Pavel Emelyanov
[snip] > > Well I clearly goofed when I added the initial network namespace support > for /proc/net. Currently things work but there are odd details visible > to user space, even when we have a single network namespace. > > Since we do not cache proc_dir_entry dentries at the moment we can > ju