Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-04 Thread Masami Hiramatsu
(2014/12/04 1:20), Steven Rostedt wrote: > On Wed, 3 Dec 2014 04:34:23 -0500 > Steven Rostedt wrote: > >> OK, I'll hold off on sending this patch then till 3.20. >> > > BTW, can we add another option that just shows the echo output. The -d > enables -x which floods the screen with lots of usele

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Steven Rostedt
On Thu, 04 Dec 2014 08:14:01 +0900 Masami Hiramatsu wrote: > >> to allow run this on busybox or dash, we'd better clean it. > > > > Do you know how to fix this? > > Yes, it's easy :). > As the tool output, [ a == b ] can be changed to [ a = b ], > and "let ..." can be changed to "$((...))" OK,

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Masami Hiramatsu
(2014/12/03 18:34), Steven Rostedt wrote: > On Wed, 03 Dec 2014 18:26:43 +0900 > Masami Hiramatsu wrote: > >> (2014/12/03 12:13), Steven Rostedt wrote: >>> From: "Steven Rostedt (Red Hat)" >>> >>> Add a test to test the event filter logic. It currently tests the >>> following filters against sch

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Steven Rostedt
On Wed, 3 Dec 2014 09:53:18 -0800 Alexei Starovoitov wrote: > aren't we all starting to hack things only to realize > that the scope of work is too large? ;) Yep. Although I did say I would only spend a few hours on a solution, and would give up if it too longer. The patches themselves took mu

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Alexei Starovoitov
On Wed, Dec 3, 2014 at 12:40 AM, Steven Rostedt wrote: > On Tue, 2 Dec 2014 22:22:16 -0800 > Alexei Starovoitov wrote: > >> On Tue, Dec 2, 2014 at 7:13 PM, Steven Rostedt wrote: >> > From: "Steven Rostedt (Red Hat)" >> > >> > Add a test to test the event filter logic. It currently tests the >>

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Steven Rostedt
On Wed, 3 Dec 2014 04:34:23 -0500 Steven Rostedt wrote: > OK, I'll hold off on sending this patch then till 3.20. > BTW, can we add another option that just shows the echo output. The -d enables -x which floods the screen with lots of useless information and it's hard to see what is going on.

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Steven Rostedt
On Wed, 03 Dec 2014 18:26:43 +0900 Masami Hiramatsu wrote: > (2014/12/03 12:13), Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Add a test to test the event filter logic. It currently tests the > > following filters against sched:sched_switch event. > > > >( prev_pid !=

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Masami Hiramatsu
(2014/12/03 12:13), Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Add a test to test the event filter logic. It currently tests the > following filters against sched:sched_switch event. > >( prev_pid != 0 ) >( prev_pid == 0 ) >( prev_pid < 100 ) >( prev_pid <= $$ )

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-03 Thread Steven Rostedt
On Tue, 2 Dec 2014 22:22:16 -0800 Alexei Starovoitov wrote: > On Tue, Dec 2, 2014 at 7:13 PM, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Add a test to test the event filter logic. It currently tests the > > following filters against sched:sched_switch event. > > > >(

Re: [PATCH 3/3] ftracetests: Add test to test event filter logic

2014-12-02 Thread Alexei Starovoitov
On Tue, Dec 2, 2014 at 7:13 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Add a test to test the event filter logic. It currently tests the > following filters against sched:sched_switch event. > >( prev_pid != 0 ) >( prev_pid == 0 ) >( prev_pid < 100 ) >( prev_