Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-04-03 Thread Richard Genoud
2013/4/3 Linus Walleij : > On Thu, Mar 28, 2013 at 4:47 PM, Richard Genoud > wrote: >> 2013/3/28 Stephen Warren : > >>> Again, pinconf_free_setting() is all about freeing any dynamically >>> allocated storage required to represent the setting itself; it's not >>> about (un-)programming HW. >>> >>

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 4:47 PM, Richard Genoud wrote: > 2013/3/28 Stephen Warren : >> Again, pinconf_free_setting() is all about freeing any dynamically >> allocated storage required to represent the setting itself; it's not >> about (un-)programming HW. >> > got it. > I'll change that I guess

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-28 Thread Richard Genoud
2013/3/28 Stephen Warren : > On 03/28/2013 04:55 AM, Richard Genoud wrote: >> 2013/3/28 Stephen Warren : >>> On 03/25/2013 08:47 AM, Richard Genoud wrote: If enabling a pin fails in pinctrl_select_state_locked(), all the previous enabled pins have to be disabled to get back to the previou

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-28 Thread Stephen Warren
On 03/28/2013 04:55 AM, Richard Genoud wrote: > 2013/3/28 Stephen Warren : >> On 03/25/2013 08:47 AM, Richard Genoud wrote: >>> If enabling a pin fails in pinctrl_select_state_locked(), all the >>> previous enabled pins have to be disabled to get back to the previous >>> state. >> >>> diff --git a/

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-28 Thread Richard Genoud
2013/3/28 Stephen Warren : > On 03/25/2013 08:47 AM, Richard Genoud wrote: >> If enabling a pin fails in pinctrl_select_state_locked(), all the >> previous enabled pins have to be disabled to get back to the previous >> state. > >> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > >> @

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-27 Thread Stephen Warren
On 03/25/2013 08:47 AM, Richard Genoud wrote: > If enabling a pin fails in pinctrl_select_state_locked(), all the > previous enabled pins have to be disabled to get back to the previous > state. > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > @@ -910,13 +910,35 @@ static int pinc

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-27 Thread Linus Walleij
On Mon, Mar 25, 2013 at 3:47 PM, Richard Genoud wrote: > If enabling a pin fails in pinctrl_select_state_locked(), all the > previous enabled pins have to be disabled to get back to the previous > state. > > Signed-off-by: Richard Genoud Thanks for fixing this! :-D Patch applied. Yours, Linus