Re: [PATCH 3/7] PM / Domain: Add struct device to genpd

2018-04-09 Thread Ulf Hansson
On 9 April 2018 at 09:53, Viresh Kumar wrote: > On 22-03-18, 11:18, Ulf Hansson wrote: >> On 22 March 2018 at 10:59, Viresh Kumar wrote: >> > On 22-03-18, 10:30, Ulf Hansson wrote: >> >> On 22 December 2017 at 08:26, Viresh Kumar >> >> wrote: > >> >> > + ret = device_add(&genpd->dev); >>

Re: [PATCH 3/7] PM / Domain: Add struct device to genpd

2018-04-09 Thread Viresh Kumar
On 22-03-18, 11:18, Ulf Hansson wrote: > On 22 March 2018 at 10:59, Viresh Kumar wrote: > > On 22-03-18, 10:30, Ulf Hansson wrote: > >> On 22 December 2017 at 08:26, Viresh Kumar wrote: > >> > + ret = device_add(&genpd->dev); > >> > >> What's the point of adding the device? Can we skip thi

Re: [PATCH 3/7] PM / Domain: Add struct device to genpd

2018-03-22 Thread Ulf Hansson
On 22 March 2018 at 10:59, Viresh Kumar wrote: > On 22-03-18, 10:30, Ulf Hansson wrote: >> On 22 December 2017 at 08:26, Viresh Kumar wrote: >> > The power-domain core would be using the OPP core going forward and the >> > OPP core has the basic requirement of a device structure for its working.

Re: [PATCH 3/7] PM / Domain: Add struct device to genpd

2018-03-22 Thread Viresh Kumar
On 22-03-18, 10:30, Ulf Hansson wrote: > On 22 December 2017 at 08:26, Viresh Kumar wrote: > > The power-domain core would be using the OPP core going forward and the > > OPP core has the basic requirement of a device structure for its working. > > According to the OPP core also seems to require

Re: [PATCH 3/7] PM / Domain: Add struct device to genpd

2018-03-22 Thread Ulf Hansson
On 22 December 2017 at 08:26, Viresh Kumar wrote: > The power-domain core would be using the OPP core going forward and the > OPP core has the basic requirement of a device structure for its working. According to the OPP core also seems to require the ->dev.of_node to be set. Actually, it seems l