Re: [PATCH 4/5] drivers: net: usb: rtl8150: bug fixing and cleanup

2013-05-19 Thread Francois Romieu
Petko Manolov : [...] > > > + usb_fill_control_urb(async_urb, dev->udev, > > > + usb_sndctrlpipe(dev->udev, 0), (void *) &req->dr, > > > > Useless void * cast. > > Wrong. The compiler actually moans quite a lot: > > /usr/src/git/rtl8150/rtl8150.c: In function ?async_set_re

Re: [PATCH 4/5] drivers: net: usb: rtl8150: bug fixing and cleanup

2013-05-19 Thread Petko Manolov
On Sat, 18 May 2013, Francois Romieu wrote: > Petko Manolov : > [...] > > static int set_registers(rtl8150_t * dev, u16 indx, u16 size, void *data) > > { > > - return usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), > > - RTL8150_REQ_SET_REGS, RTL8150_REQT_WR

Re: [PATCH 4/5] drivers: net: usb: rtl8150: bug fixing and cleanup

2013-05-18 Thread Francois Romieu
Petko Manolov : [...] > static int set_registers(rtl8150_t * dev, u16 indx, u16 size, void *data) > { > - return usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), > -RTL8150_REQ_SET_REGS, RTL8150_REQT_WRITE, > -indx, 0, data, si