Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-19 Thread LABBE Corentin
On Fri, Sep 18, 2020 at 06:09:15PM +1000, Herbert Xu wrote: > On Fri, Sep 18, 2020 at 10:06:58AM +0200, LABBE Corentin wrote: > > > > But I think only me will see it and since I already have this on my TODO > > list, I dont see any interest to leave it failing. > > Furthermore, having a clean BE b

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-18 Thread Herbert Xu
On Fri, Sep 18, 2020 at 10:06:58AM +0200, LABBE Corentin wrote: > > But I think only me will see it and since I already have this on my TODO > list, I dont see any interest to leave it failing. > Furthermore, having a clean BE boot will permit to enable BE boots for thoses > SoCs on kernelCI. I'

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-18 Thread LABBE Corentin
On Fri, Sep 18, 2020 at 05:31:28PM +1000, Herbert Xu wrote: > On Thu, Sep 17, 2020 at 06:35:55PM +, Corentin Labbe wrote: > > Ciphers produce invalid results on BE. > > Key and IV need to be written in LE. > > Furthermore, the non-optimized function is too complicated to convert, > > let's simp

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-18 Thread Herbert Xu
On Thu, Sep 17, 2020 at 06:35:55PM +, Corentin Labbe wrote: > Ciphers produce invalid results on BE. > Key and IV need to be written in LE. > Furthermore, the non-optimized function is too complicated to convert, > let's simply fallback on BE for the moment. > > Fixes: 6298e948215f2 ("crypto: