Re: [PATCH 9/9] ARM: add uprobes support

2013-08-29 Thread Jon Medhurst (Tixy)
On Thu, 2013-08-01 at 19:45 -0400, David Long wrote: > From: "David A. Long" > > Using Rabin Vincent's ARM uprobes patches as a base, enable uprobes > support on ARM. > > Caveats: > > - Thumb is not supported Do you know if there any plans for this to be worked on? I believe most distros targ

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-21 Thread Rabin Vincent
On Mon, Oct 15, 2012 at 06:44:50PM +0100, Dave Martin wrote: > On Mon, Oct 15, 2012 at 01:44:55PM +0200, Rabin Vincent wrote: > > Why? It currently works for ARM userspace even if the kernel is > > Thumb-2. > > My bad, I misread what was happening in the Makefile changes. > > My concern is about

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-21 Thread Rabin Vincent
On Wed, Oct 17, 2012 at 03:50:48PM +0100, Jon Medhurst (Tixy) wrote: > I just been looking at the decoding changes in patch 8 and had similar > thoughts. The patch as it stands looks rather bolted on the side and > makes the resulting code rather messy. I agree. > a) uprobes is similar enough to

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-21 Thread Rabin Vincent
On Mon, Oct 15, 2012 at 06:31:47PM +0100, Dave Martin wrote: > On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: > > +static int uprobe_trap_handler(struct pt_regs *regs, unsigned int instr) > > +{ > > + unsigned long flags; > > + > > + local_irq_save(flags); > > + if ((instr & 0

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-17 Thread Oleg Nesterov
On 10/14, Rabin Vincent wrote: > > @@ -655,6 +656,9 @@ do_work_pending(struct pt_regs *regs, unsigned int > thread_flags, int syscall) > return restart; > } > syscall = 0; > + } el

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-17 Thread Jon Medhurst (Tixy)
On Mon, 2012-10-15 at 18:44 +0100, Dave Martin wrote: > On Mon, Oct 15, 2012 at 01:44:55PM +0200, Rabin Vincent wrote: > > 2012/10/15 Dave Martin : > > > On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: > > >> Add basic uprobes support for ARM. > > >> > > >> perf probe --exec and Syst

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-15 Thread Dave Martin
On Mon, Oct 15, 2012 at 01:44:55PM +0200, Rabin Vincent wrote: > 2012/10/15 Dave Martin : > > On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: > >> Add basic uprobes support for ARM. > >> > >> perf probe --exec and SystemTap's userspace probing work. The ARM > >> kprobes test code ha

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-15 Thread Dave Martin
On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: > Add basic uprobes support for ARM. > > perf probe --exec and SystemTap's userspace probing work. The ARM > kprobes test code has also been run in a userspace harness to test the > uprobe instruction decoding. > > Caveats: > > - T

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-15 Thread Rabin Vincent
2012/10/15 Dave Martin : > On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: >> Add basic uprobes support for ARM. >> >> perf probe --exec and SystemTap's userspace probing work. The ARM >> kprobes test code has also been run in a userspace harness to test the >> uprobe instruction de

Re: [PATCH 9/9] ARM: add uprobes support

2012-10-15 Thread Dave Martin
On Sun, Oct 14, 2012 at 09:23:13PM +0200, Rabin Vincent wrote: > Add basic uprobes support for ARM. > > perf probe --exec and SystemTap's userspace probing work. The ARM > kprobes test code has also been run in a userspace harness to test the > uprobe instruction decoding. The assumption that th