Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Matthew Garrett
On Wed, Sep 05, 2012 at 02:30:10PM +0100, Alan Cox wrote: > On Wed, 5 Sep 2012 14:20:07 +0100 > Matthew Garrett wrote: > > We've no good way of knowing what the firmware's giving us - we copy it > > to RAM in the EFI init process, so by the time we're here it certainly > > shouldn't be on the PC

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Alan Cox
On Wed, 5 Sep 2012 14:20:07 +0100 Matthew Garrett wrote: > On Wed, Sep 05, 2012 at 01:46:21PM +0100, Alan Cox wrote: > > On Wed, 5 Sep 2012 03:29:32 +0100 > > Matthew Garrett wrote: > > > > > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > > > /* > > > > >+ * Some

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Matthew Garrett
On Wed, Sep 05, 2012 at 01:46:21PM +0100, Alan Cox wrote: > On Wed, 5 Sep 2012 03:29:32 +0100 > Matthew Garrett wrote: > > > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > > /* > > > >+ * Some devices may provide ROMs via a source other than the BAR > > > >+

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Alan Cox
On Wed, 5 Sep 2012 03:29:32 +0100 Matthew Garrett wrote: > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > /* > > >+ * Some devices may provide ROMs via a source other than the BAR > > >+ */ > > >+ if (pdev->rom&& pdev->romlen) { > > >+ *size = pdev->romlen; > >

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-04 Thread Matthew Garrett
On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > /* > >+ * Some devices may provide ROMs via a source other than the BAR > >+ */ > >+if (pdev->rom&& pdev->romlen) { > >+*size = pdev->romlen; > >+return phys_to_virt((phys_addr_t)pdev->rom); >

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-04 Thread Don Dutile
On 08/23/2012 12:36 PM, Matthew Garrett wrote: Platforms may provide their own mechanisms for obtaining ROMs. Add support for using data provided by the platform in that case. Signed-off-by: Matthew Garrett --- drivers/pci/rom.c | 11 +-- include/linux/pci.h | 2 ++ 2 files change