Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-27 Thread Jiri Olsa
On Tue, Mar 27, 2018 at 09:17:57PM +0800, Jin, Yao wrote: SNIP > > +#define IS_BUILTIN(option) __is_defined(option) > > + > > + > > +static void status_print(const char *name, const char *status) > > +{ > > + printf("%22s: [ %3s ]\n", name, status); > > +} > > + > > int cmd_version(int argc _

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-27 Thread Jin, Yao
On 3/27/2018 8:38 PM, Jiri Olsa wrote: On Mon, Mar 26, 2018 at 09:51:03PM +0800, Jin, Yao wrote: On 3/26/2018 5:39 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: This patch checks the values passed by CFLAGS (-DXXX) and then print the status of libraries. Fo

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-27 Thread Jin, Yao
On 3/27/2018 8:56 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 09:44:23AM +0800, Jin, Yao wrote: On 3/26/2018 5:39 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: This patch checks the values passed by CFLAGS (-DXXX) and then print the status of libraries. Fo

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-27 Thread Jiri Olsa
On Tue, Mar 27, 2018 at 09:44:23AM +0800, Jin, Yao wrote: > > > On 3/26/2018 5:39 PM, Jiri Olsa wrote: > > On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: > > > This patch checks the values passed by CFLAGS (-DXXX) and then > > > print the status of libraries. > > > > > > For example, i

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-27 Thread Jiri Olsa
On Mon, Mar 26, 2018 at 09:51:03PM +0800, Jin, Yao wrote: > > > On 3/26/2018 5:39 PM, Jiri Olsa wrote: > > On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: > > > This patch checks the values passed by CFLAGS (-DXXX) and then > > > print the status of libraries. > > > > > > For example, i

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Jin, Yao
On 3/27/2018 1:58 PM, Ingo Molnar wrote: * Jin Yao wrote: +#ifdef HAVE_DWARF_SUPPORT +#ifdef HAVE_DWARF_GETLOCATIONS +#ifdef NO_GLIBC +#ifdef HAVE_GTK2_SUPPORT +#ifdef HAVE_LIBAUDIT_SUPPORT +#ifdef HAVE_LIBBFD_SUPPORT +#ifdef HAVE_LIBELF_SUPPORT +#ifdef HAVE_LIBNUMA_SUPPORT +#ifdef NO_LIBPE

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Ingo Molnar
* Jin Yao wrote: > +#ifdef HAVE_DWARF_SUPPORT > +#ifdef HAVE_DWARF_GETLOCATIONS > +#ifdef NO_GLIBC > +#ifdef HAVE_GTK2_SUPPORT > +#ifdef HAVE_LIBAUDIT_SUPPORT > +#ifdef HAVE_LIBBFD_SUPPORT > +#ifdef HAVE_LIBELF_SUPPORT > +#ifdef HAVE_LIBNUMA_SUPPORT > +#ifdef NO_LIBPERL > +#ifdef NO_LIBPYTHON >

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Jin, Yao
On 3/26/2018 9:51 PM, Jin, Yao wrote: On 3/26/2018 5:39 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: This patch checks the values passed by CFLAGS (-DXXX) and then print the status of libraries. For example, if HAVE_DWARF_SUPPORT is defined, that means the

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Jin, Yao
On 3/26/2018 5:39 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: This patch checks the values passed by CFLAGS (-DXXX) and then print the status of libraries. For example, if HAVE_DWARF_SUPPORT is defined, that means the library "dwarf" is compiled-in. The patch

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Jin, Yao
On 3/26/2018 5:39 PM, Jiri Olsa wrote: On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: This patch checks the values passed by CFLAGS (-DXXX) and then print the status of libraries. For example, if HAVE_DWARF_SUPPORT is defined, that means the library "dwarf" is compiled-in. The patch

Re: [PATCH v1 2/3] perf version: Print the status of compiled-in libraries

2018-03-26 Thread Jiri Olsa
On Tue, Mar 27, 2018 at 12:07:03AM +0800, Jin Yao wrote: > This patch checks the values passed by CFLAGS (-DXXX) and then > print the status of libraries. > > For example, if HAVE_DWARF_SUPPORT is defined, that means the > library "dwarf" is compiled-in. The patch will print the status > "on" for