Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread Sudeep Holla
On 24/05/18 15:52, ilia...@codeaurora.org wrote: > OK, got you. > Is "operating-points-v2-kryo-cpu" good enough? > Not sure if I can answer that as I don't have full knowledge on PM on all Kryo CPUs. Will this driver work on all those platforms which will have "operating-points-v2-kryo-cpu" ? I

RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
rnel@vger.kernel.org; > vire...@kernel.org; n...@ti.com; sb...@kernel.org; r...@kernel.org; > mark.rutl...@arm.com; r...@rjwysocki.net > Subject: Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver > > > > On 24/05/18 15:10, ilia...@codeaurora.org wrote: > > Thank you

Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread Sudeep Holla
On 24/05/18 15:10, ilia...@codeaurora.org wrote: > Thank you for the explanation. However, could you suggest, which > condition should I check then? Device tree? > Yes some compatible which is applicable for all the SoCs or platforms on which this driver can work ? -- Regards, Sudeep

RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
r...@kernel.org; mark.rutl...@arm.com; > r...@rjwysocki.net > Cc: Sudeep Holla ; linux...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver > > > > On 24/05

Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread Sudeep Holla
On 24/05/18 14:03, ilia...@codeaurora.org wrote: > > [...] >>> + >>> + ret = PTR_ERR_OR_ZERO(platform_device_register_simple( >>> + "qcom-cpufreq-kryo", -1, NULL, 0)); >> >> >> You simply can't do this unconditionally here. This will blow up on platforms >> where this driver is no

RE: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread ilialin
vicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver > > Hi Ilia, > > > On 24/05/18 09:57, Ilia Lin wrote: > > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO > > processors, the CPU fre

Re: [PATCH v12 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-24 Thread Sudeep Holla
Hi Ilia, On 24/05/18 09:57, Ilia Lin wrote: > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > the CPU frequency subset and voltage value of each OPP varies > based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables > defines the voltage and frequency