Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-31 Thread Helmut Klein
On 31.03.2017 17:37, Jerome Brunet wrote: On Wed, 2017-03-29 at 13:21 -0700, Kevin Hilman wrote: Martin Blumenstingl writes: [...] for Helmut this would mean that instead of dropping this patch (or dropping CLKID_UART1 and CLKID_UART2 from this patch) he would rather have to *add* another pa

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-31 Thread Jerome Brunet
On Wed, 2017-03-29 at 13:21 -0700, Kevin Hilman wrote: > Martin Blumenstingl writes: > > [...] > > > for Helmut this would mean that instead of dropping this patch (or > > dropping CLKID_UART1 and CLKID_UART2 from this patch) he would rather > > have to *add* another patch (for meson-gxbb.dtsi a

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-29 Thread Kevin Hilman
Martin Blumenstingl writes: [...] > for Helmut this would mean that instead of dropping this patch (or > dropping CLKID_UART1 and CLKID_UART2 from this patch) he would rather > have to *add* another patch (for meson-gxbb.dtsi and meson-gxl.dtsi) > which passes the core clocks to the correspondin

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-28 Thread Jerome Brunet
On Tue, 2017-03-28 at 23:24 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Mar 28, 2017 at 9:14 PM, Jerome Brunet wrote: > > On Tue, 2017-03-28 at 20:18 +0200, Helmut Klein wrote: > > > i know for sure that the bluetooth chip of my system is connected to > > > uart_A. so this clock mu

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-28 Thread Martin Blumenstingl
Hi Jerome, On Tue, Mar 28, 2017 at 9:14 PM, Jerome Brunet wrote: > On Tue, 2017-03-28 at 20:18 +0200, Helmut Klein wrote: >> i know for sure that the bluetooth chip of my system is connected to >> uart_A. so this clock must be exposed. >> >> i don't know if the other 2 uarts are used on other har

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-28 Thread Jerome Brunet
On Tue, 2017-03-28 at 20:18 +0200, Helmut Klein wrote: > i know for sure that the bluetooth chip of my system is connected to  > uart_A. so this clock must be exposed. > > i don't know if the other 2 uarts are used on other hardware. so i will  > remove them from my patch. What I meant is device

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-28 Thread Helmut Klein
i know for sure that the bluetooth chip of my system is connected to uart_A. so this clock must be exposed. i don't know if the other 2 uarts are used on other hardware. so i will remove them from my patch. Helmut On 28.03.2017 17:51, Jerome Brunet wrote: On Tue, 2017-03-28 at 11:25 +0200,

Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx

2017-03-28 Thread Jerome Brunet
On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote: > Expose the clock ids for the three none AO uarts to the dt-bindings Are they all used in the device tree ? We try to only expose what we need in the DT The recent discussion over CLKID_CPUCLK proved it was a sane thing to do. > > Signed-of