Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Christian Lamparter
On Friday, August 22, 2014 04:23:19 PM Eric Dumazet wrote: > On Fri, 2014-08-22 at 23:53 +0200, Christian Lamparter wrote: > > > The sta_info->agg[tid] check is not needed (for reference, see [0]). > > (There is already a check in mac80211 which prevents the leak of > > sta_info->agg[tid] [1]). >

Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Eric Dumazet
On Fri, 2014-08-22 at 23:53 +0200, Christian Lamparter wrote: > The sta_info->agg[tid] check is not needed (for reference, see [0]). > (There is already a check in mac80211 which prevents the leak of > sta_info->agg[tid] [1]). > > Regards > Christian > > [0]

Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Christian Lamparter
On Friday, August 22, 2014 02:08:52 PM Eric Dumazet wrote: > On Fri, 2014-08-22 at 22:38 +0200, Christian Lamparter wrote: > [...] > > From: Andreea-Cristina Bernat > > > > The carl9170_op_ampdu_action() function is used only by the mac80211 > > framework. Since the mac80211 already takes care of

Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Eric Dumazet
On Fri, 2014-08-22 at 22:38 +0200, Christian Lamparter wrote: > On Friday, August 22, 2014 10:14:31 PM Andreea-Cristina Bernat wrote: > > The carl9170_op_ampdu_action() function is used only by the mac80211 > > framework. Since the mac80211 already takes care of checks and > > properly serializing

Re: [PATCH v2] carl9170: Remove redundant protection check

2014-08-22 Thread Christian Lamparter
On Friday, August 22, 2014 10:14:31 PM Andreea-Cristina Bernat wrote: > The carl9170_op_ampdu_action() function is used only by the mac80211 > framework. Since the mac80211 already takes care of checks and > properly serializing calls to the driver's function there is no > need for the driver to d