Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Brian Gerst
On Sat, Aug 6, 2016 at 1:25 AM, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: >> The 8 should be changed to SIZEOF_PTREGS in a later patch >> ("x86/asm/head: standardize the end of the stack for idle tasks"). > > But SIZEOF_PTREGS is

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Brian Gerst
On Sat, Aug 6, 2016 at 1:25 AM, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: >> The 8 should be changed to SIZEOF_PTREGS in a later patch >> ("x86/asm/head: standardize the end of the stack for idle tasks"). > > But SIZEOF_PTREGS is 21*8. I don't

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Josh Poimboeuf
On Sat, Aug 06, 2016 at 09:15:30AM -0400, Brian Gerst wrote: > On Sat, Aug 6, 2016 at 1:25 AM, Borislav Petkov wrote: > > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > >> The 8 should be changed to SIZEOF_PTREGS in a later patch > >> ("x86/asm/head: standardize

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Josh Poimboeuf
On Sat, Aug 06, 2016 at 09:15:30AM -0400, Brian Gerst wrote: > On Sat, Aug 6, 2016 at 1:25 AM, Borislav Petkov wrote: > > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > >> The 8 should be changed to SIZEOF_PTREGS in a later patch > >> ("x86/asm/head: standardize the end of the

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Borislav Petkov
On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > The 8 should be changed to SIZEOF_PTREGS in a later patch > ("x86/asm/head: standardize the end of the stack for idle tasks"). But SIZEOF_PTREGS is 21*8. I don't understand. -- Regards/Gruss, Boris. ECO tip #101: Trim your

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Borislav Petkov
On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > The 8 should be changed to SIZEOF_PTREGS in a later patch > ("x86/asm/head: standardize the end of the stack for idle tasks"). But SIZEOF_PTREGS is 21*8. I don't understand. -- Regards/Gruss, Boris. ECO tip #101: Trim your

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Josh Poimboeuf
On Sat, Aug 06, 2016 at 07:25:21AM +0200, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > > The 8 should be changed to SIZEOF_PTREGS in a later patch > > ("x86/asm/head: standardize the end of the stack for idle tasks"). > > But SIZEOF_PTREGS is 21*8. I

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-06 Thread Josh Poimboeuf
On Sat, Aug 06, 2016 at 07:25:21AM +0200, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 11:01:57AM -0500, Josh Poimboeuf wrote: > > The 8 should be changed to SIZEOF_PTREGS in a later patch > > ("x86/asm/head: standardize the end of the stack for idle tasks"). > > But SIZEOF_PTREGS is 21*8. I

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-05 Thread Josh Poimboeuf
On Fri, Aug 05, 2016 at 10:28:39AM -0500, Nilay Vaish wrote: > On 4 August 2016 at 17:21, Josh Poimboeuf wrote: > > The 'stack_start' variable is similar in usage to 'initial_code' and > > 'initial_gs': they're all stored in head_64.S and they're all updated by > > SMP and

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-05 Thread Josh Poimboeuf
On Fri, Aug 05, 2016 at 10:28:39AM -0500, Nilay Vaish wrote: > On 4 August 2016 at 17:21, Josh Poimboeuf wrote: > > The 'stack_start' variable is similar in usage to 'initial_code' and > > 'initial_gs': they're all stored in head_64.S and they're all updated by > > SMP and ACPI suspend before

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-05 Thread Nilay Vaish
On 4 August 2016 at 17:21, Josh Poimboeuf wrote: > The 'stack_start' variable is similar in usage to 'initial_code' and > 'initial_gs': they're all stored in head_64.S and they're all updated by > SMP and ACPI suspend before starting a CPU. > > Rename it to 'initial_stack' to

Re: [PATCH v2 03/44] x86/asm/head: rename 'stack_start' -> 'initial_stack'

2016-08-05 Thread Nilay Vaish
On 4 August 2016 at 17:21, Josh Poimboeuf wrote: > The 'stack_start' variable is similar in usage to 'initial_code' and > 'initial_gs': they're all stored in head_64.S and they're all updated by > SMP and ACPI suspend before starting a CPU. > > Rename it to 'initial_stack' to be consistent with