Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-21 Thread Andy Lutomirski
On Tue, Jun 21, 2016 at 1:46 AM, Michal Hocko wrote: > On Mon 20-06-16 09:13:55, Andy Lutomirski wrote: >> On Mon, Jun 20, 2016 at 6:36 AM, Michal Hocko wrote: >> > On Fri 17-06-16 13:00:42, Andy Lutomirski wrote: >> >> If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with >> >> vmal

Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-21 Thread Michal Hocko
On Mon 20-06-16 09:13:55, Andy Lutomirski wrote: > On Mon, Jun 20, 2016 at 6:36 AM, Michal Hocko wrote: > > On Fri 17-06-16 13:00:42, Andy Lutomirski wrote: > >> If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with > >> vmalloc_node. > > > > I like this! It also reduces demand for hi

Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-20 Thread Andy Lutomirski
On Mon, Jun 20, 2016 at 6:36 AM, Michal Hocko wrote: > On Fri 17-06-16 13:00:42, Andy Lutomirski wrote: >> If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with >> vmalloc_node. > > I like this! It also reduces demand for higher order (order-2) pages > considerably which is a great pl

Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-20 Thread Michal Hocko
On Fri 17-06-16 13:00:42, Andy Lutomirski wrote: > If CONFIG_VMAP_STACK is selected, kernel stacks are allocated with > vmalloc_node. I like this! It also reduces demand for higher order (order-2) pages considerably which is a great plus on its own. I would be little bit worried about the performa

Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-17 Thread Andy Lutomirski
On Fri, Jun 17, 2016 at 1:57 PM, Josh Poimboeuf wrote: > On Fri, Jun 17, 2016 at 01:00:42PM -0700, Andy Lutomirski wrote: >> @@ -213,24 +232,46 @@ struct kmem_cache *vm_area_cachep; >> /* SLAB cache for mm_struct structures (tsk->mm) */ >> static struct kmem_cache *mm_cachep; >> >> -static void

Re: [PATCH v2 06/13] fork: Add generic vmalloced stack support

2016-06-17 Thread Josh Poimboeuf
On Fri, Jun 17, 2016 at 01:00:42PM -0700, Andy Lutomirski wrote: > @@ -213,24 +232,46 @@ struct kmem_cache *vm_area_cachep; > /* SLAB cache for mm_struct structures (tsk->mm) */ > static struct kmem_cache *mm_cachep; > > -static void account_kernel_stack(struct thread_info *ti, int account) > +