Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Rafael J. Wysocki
On Friday, November 16, 2012 10:09:34 PM Mika Westerberg wrote: > On Fri, Nov 16, 2012 at 09:02:36PM +0100, Rafael J. Wysocki wrote: > > Ah, that's what's called by acpi_dev_get_resources(). But what about > > writing > > it this way: > > > > static int acpi_i2c_find_child_address(struct acpi_re

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Mika Westerberg
On Fri, Nov 16, 2012 at 09:02:36PM +0100, Rafael J. Wysocki wrote: > Ah, that's what's called by acpi_dev_get_resources(). But what about writing > it this way: > > static int acpi_i2c_find_child_address(struct acpi_resource *ares, void *data) > { > >if (ares->type == ACPI_RESOURCE_TYPE_

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Rafael J. Wysocki
On Friday, November 16, 2012 04:17:29 PM Mika Westerberg wrote: > On Fri, Nov 16, 2012 at 02:42:56PM +0100, Jean Delvare wrote: > > On Fri, 16 Nov 2012 14:21:54 +0100, Rafael J. Wysocki wrote: > > > On Friday, November 16, 2012 02:03:57 PM Jean Delvare wrote: > > > > Hi Rafael, > > > > > > > > On

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Jean Delvare
Hi Mika, On Fri, 16 Nov 2012 17:23:32 +0200, Mika Westerberg wrote: > Here's the updated version where we handle 10-bit addresses properly > (hopefully). > (...) > +static int acpi_i2c_find_device(struct device *dev, acpi_handle *handle) > +{ > (...) > + memset(&i2c_find, 0, sizeof(i2c_find));

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Mika Westerberg
On Fri, Nov 16, 2012 at 04:17:29PM +0200, Mika Westerberg wrote: > > > > > +static int acpi_i2c_find_child_address(struct acpi_resource *ares, > > > > > void *data) > > > > > +{ > > > > > + struct acpi_resource_i2c_serialbus *sb; > > > > > + struct acpi_i2c_find *i2c_find = data; > > > > >

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Mika Westerberg
On Fri, Nov 16, 2012 at 02:42:56PM +0100, Jean Delvare wrote: > On Fri, 16 Nov 2012 14:21:54 +0100, Rafael J. Wysocki wrote: > > On Friday, November 16, 2012 02:03:57 PM Jean Delvare wrote: > > > Hi Rafael, > > > > > > On Fri, 16 Nov 2012 11:09:03 +0100, Rafael J. Wysocki wrote: > > > > On Thursda

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Jean Delvare
On Fri, 16 Nov 2012 14:21:54 +0100, Rafael J. Wysocki wrote: > On Friday, November 16, 2012 02:03:57 PM Jean Delvare wrote: > > Hi Rafael, > > > > On Fri, 16 Nov 2012 11:09:03 +0100, Rafael J. Wysocki wrote: > > > On Thursday, November 15, 2012 01:03:17 PM Mika Westerberg wrote: > > > > ACPI 5 int

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Rafael J. Wysocki
On Friday, November 16, 2012 02:03:57 PM Jean Delvare wrote: > Hi Rafael, > > On Fri, 16 Nov 2012 11:09:03 +0100, Rafael J. Wysocki wrote: > > On Thursday, November 15, 2012 01:03:17 PM Mika Westerberg wrote: > > > ACPI 5 introduced I2cSerialBus resource that makes it possible to > > > enumerate

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Jean Delvare
Hi Rafael, On Fri, 16 Nov 2012 11:09:03 +0100, Rafael J. Wysocki wrote: > On Thursday, November 15, 2012 01:03:17 PM Mika Westerberg wrote: > > ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate > > and configure the I2C slave devices behind the I2C controller. This patch

Re: [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-16 Thread Rafael J. Wysocki
On Thursday, November 15, 2012 01:03:17 PM Mika Westerberg wrote: > ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate > and configure the I2C slave devices behind the I2C controller. This patch > adds helper functions to support I2C slave enumeration. > > An ACPI enabled