Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter

2019-03-26 Thread Baoquan He
On 03/26/19 at 04:43am, Matthew Wilcox wrote: > On Tue, Mar 26, 2019 at 05:02:27PM +0800, Baoquan He wrote: > > The input parameter 'phys_index' of memory_block_action() is actually > > the section number, but not the phys_index of memory_block. Fix it. > > > static int > > -memory_block_action(u

Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter

2019-03-26 Thread Matthew Wilcox
On Tue, Mar 26, 2019 at 05:02:27PM +0800, Baoquan He wrote: > The input parameter 'phys_index' of memory_block_action() is actually > the section number, but not the phys_index of memory_block. Fix it. > static int > -memory_block_action(unsigned long phys_index, unsigned long action, int > onli

Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter

2019-03-26 Thread Michal Hocko
On Tue 26-03-19 17:02:27, Baoquan He wrote: > The input parameter 'phys_index' of memory_block_action() is actually > the section number, but not the phys_index of memory_block. Fix it. phys_index is a relict from the past and it indeed denotes the section number which is exported as phys_index vi

Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter

2019-03-26 Thread Rafael J. Wysocki
On Tue, Mar 26, 2019 at 10:02 AM Baoquan He wrote: > > The input parameter 'phys_index' of memory_block_action() is actually > the section number, but not the phys_index of memory_block. Fix it. > > Signed-off-by: Baoquan He > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" Reviewed-by: Rafae