Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Jiri Kosina
On Wed, 12 Apr 2017, Carlo Caione wrote: > > I'll drop the cancel_work_sync() call while doing it, ok? > > Sure, go for it. Applied to hid.git#for-4.12/asus. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Jiri Kosina
On Wed, 12 Apr 2017, Carlo Caione wrote: > > I'll drop the cancel_work_sync() call while doing it, ok? > > Sure, go for it. Applied to hid.git#for-4.12/asus. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina wrote: > On Wed, 12 Apr 2017, Carlo Caione wrote: > >> >> + ret = devm_led_classdev_register(>dev, >> >> >kbd_backlight->cdev); >> >> + if (ret < 0) { >> >> + /* No need to have this still around */ >> >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina wrote: > On Wed, 12 Apr 2017, Carlo Caione wrote: > >> >> + ret = devm_led_classdev_register(>dev, >> >> >kbd_backlight->cdev); >> >> + if (ret < 0) { >> >> + /* No need to have this still around */ >> >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Jiri Kosina
On Wed, 12 Apr 2017, Carlo Caione wrote: > >> + ret = devm_led_classdev_register(>dev, > >> >kbd_backlight->cdev); > >> + if (ret < 0) { > >> + /* No need to have this still around */ > >> + devm_kfree(>dev, drvdata->kbd_backlight); > >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Jiri Kosina
On Wed, 12 Apr 2017, Carlo Caione wrote: > >> + ret = devm_led_classdev_register(>dev, > >> >kbd_backlight->cdev); > >> + if (ret < 0) { > >> + /* No need to have this still around */ > >> + devm_kfree(>dev, drvdata->kbd_backlight); > >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote: >> + ret = devm_led_classdev_register(>dev, >> >kbd_backlight->cdev); >> + if (ret < 0) { >> + /* No need to have this still around

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-12 Thread Carlo Caione
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote: >> + ret = devm_led_classdev_register(>dev, >> >kbd_backlight->cdev); >> + if (ret < 0) { >> + /* No need to have this still around */ >> +

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-10 Thread Benjamin Tissoires
On Apr 06 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The firmware

Re: [PATCH v3] HID: asus: support backlight on USB keyboards

2017-04-10 Thread Benjamin Tissoires
On Apr 06 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The firmware implements at least 3