Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-09 Thread Toshi Kani
On Mon, 2016-05-09 at 16:34 -0600, Toshi Kani wrote: > On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote:  : > > > > > > > > > > This patch should replace blkdev_dax_capable(), or just reuse > > > > > that existing routine, or am I missing something? > > > > > > > > Good question.  bdev_suppor

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-09 Thread Toshi Kani
On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote: > On Mon, May 09, 2016 at 11:23:03AM -0700, Dan Williams wrote: > > > > On Mon, May 9, 2016 at 11:12 AM, Toshi Kani wrote: > > > > > > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: > > > > > > > > On Thu, May 5, 2016 at 5:29 PM, To

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-09 Thread Dave Chinner
On Mon, May 09, 2016 at 11:23:03AM -0700, Dan Williams wrote: > On Mon, May 9, 2016 at 11:12 AM, Toshi Kani wrote: > > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: > >> On Thu, May 5, 2016 at 5:29 PM, Toshi Kani wrote: > > : > >> > +int bdev_supports_dax(struct super_block *sb, int blo

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-09 Thread Dan Williams
On Mon, May 9, 2016 at 11:12 AM, Toshi Kani wrote: > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: >> On Thu, May 5, 2016 at 5:29 PM, Toshi Kani wrote: > : >> > +int bdev_supports_dax(struct super_block *sb, int blocksize) >> > +{ >> > + struct blk_dax_ctl dax = { >> > +

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-09 Thread Toshi Kani
On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: > On Thu, May 5, 2016 at 5:29 PM, Toshi Kani wrote:  : > > +int bdev_supports_dax(struct super_block *sb, int blocksize) > > +{ > > +   struct blk_dax_ctl dax = { > > +   .sector = 0, > > +   .size = PAGE_SIZE, > >

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-08 Thread Dan Williams
On Thu, May 5, 2016 at 5:29 PM, Toshi Kani wrote: > DAX imposes additional requirements to a device. Add > bdev_supports_dax() which performs all the precondition checks > necessary for filesystem to mount the device with dax option. > > Also add a new check to verify if a partition is aligned by

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-08 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig