Re: [PATCH v4 2/3] rust: macros: add macro to easily run KUnit tests

2024-11-03 Thread Miguel Ojeda
On Sat, Nov 2, 2024 at 1:08 AM Boqun Feng wrote: > > Hmm.. so I think clippy won't warn for a normal Rust #[test] function: > > https://github.com/rust-lang/rust-clippy/pull/7811 That is a very good point. It is a bit surprising that those details are not documented, but we could mimic th

Re: [PATCH v4 2/3] rust: macros: add macro to easily run KUnit tests

2024-11-01 Thread Boqun Feng
On Fri, Nov 01, 2024 at 11:12:06PM +0100, Miguel Ojeda wrote: > On Fri, Nov 1, 2024 at 10:38 PM Boqun Feng wrote: > > > > but this lint doesn't make sense to me, I would say we just drop this > > lint? > > I am not sure if it is intended to fire there (i.e. to resolve > constants), but seems OK s

Re: [PATCH v4 2/3] rust: macros: add macro to easily run KUnit tests

2024-11-01 Thread Miguel Ojeda
On Fri, Nov 1, 2024 at 10:38 PM Boqun Feng wrote: > > but this lint doesn't make sense to me, I would say we just drop this > lint? I am not sure if it is intended to fire there (i.e. to resolve constants), but seems OK since it is not something one would want normally to write except in exceptio