Re: [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro

2018-10-16 Thread William Breathitt Gray
On Mon, Oct 15, 2018 at 01:59:33PM +0200, Rasmus Villemoes wrote: > On 2018-10-14 06:19, William Breathitt Gray wrote: > > > a bit value of 0 in the > > bits array does not necessarily mean the input was not requested, but > > may instead mean that the value at the input is 0; > > sure enough, bu

Re: [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro

2018-10-15 Thread Rasmus Villemoes
On 2018-10-14 06:19, William Breathitt Gray wrote: > a bit value of 0 in the > bits array does not necessarily mean the input was not requested, but > may instead mean that the value at the input is 0; sure enough, but... > therefore, the caller > must keep track of the requested inputs rather t

Re: [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro

2018-10-13 Thread William Breathitt Gray
On Tue, Oct 02, 2018 at 09:00:45AM +0200, Rasmus Villemoes wrote: > On 2018-10-02 03:14, William Breathitt Gray wrote: > > /* clear bits array to a clean slate */ > > bitmap_zero(bits, chip->ngpio); > > > > - /* get bits are evaluated a gpio port register at a time */ > > - for (i = 0

Re: [RESEND PATCH v4 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump macro

2018-10-02 Thread Rasmus Villemoes
On 2018-10-02 03:14, William Breathitt Gray wrote: > /* clear bits array to a clean slate */ > bitmap_zero(bits, chip->ngpio); > > - /* get bits are evaluated a gpio port register at a time */ > - for (i = 0; i < ARRAY_SIZE(ports); i++) { > - /* gpio offset in bits