Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-31 Thread Rusty Russell
Ming Lei writes: > On Thu, Oct 31, 2013 at 11:14 AM, Rusty Russell wrote: >> Russell King - ARM Linux writes: >> >> Kallsyms tends to fall between modules and scripts. I assume it's not >> urgent, so no cc:stable on this one. > > Rusty, thanks a lot. > > BTW, there is already other report on t

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-30 Thread Ming Lei
On Thu, Oct 31, 2013 at 11:14 AM, Rusty Russell wrote: > Russell King - ARM Linux writes: > > Kallsyms tends to fall between modules and scripts. I assume it's not > urgent, so no cc:stable on this one. Rusty, thanks a lot. BTW, there is already other report on the problem: http://lkml.ind

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-30 Thread Rusty Russell
Russell King - ARM Linux writes: > On Mon, Oct 28, 2013 at 04:20:19PM +1030, Rusty Russell wrote: >> Ming Lei writes: >> > On Mon, 28 Oct 2013 13:44:30 +1030 >> > Rusty Russell wrote: >> > >> >> Ming Lei writes: >> >> >> >> I don't know... It would be your job, as the person making the change

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-30 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 04:20:19PM +1030, Rusty Russell wrote: > Ming Lei writes: > > On Mon, 28 Oct 2013 13:44:30 +1030 > > Rusty Russell wrote: > > > >> Ming Lei writes: > >> > >> I don't know... It would be your job, as the person making the change, > >> to find all the users of kallsyms an

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-27 Thread Rusty Russell
Ming Lei writes: > On Mon, 28 Oct 2013 13:44:30 +1030 > Rusty Russell wrote: > >> Ming Lei writes: >> >> I don't know... It would be your job, as the person making the change, >> to find all the users of kallsyms and prove that. >> >> This is why it is easier not to include incorrect values i

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-27 Thread Ming Lei
On Mon, 28 Oct 2013 13:44:30 +1030 Rusty Russell wrote: > Ming Lei writes: > > I don't know... It would be your job, as the person making the change, > to find all the users of kallsyms and prove that. > > This is why it is easier not to include incorrect values in the kernel's > kallsyms in

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-27 Thread Rusty Russell
Ming Lei writes: > On Fri, Oct 25, 2013 at 7:58 PM, Rusty Russell wrote: >>> >>> Basically these symbols are only used to generate code, and in >>> kernel mode, CPU won't run into the corresponding addresses >>> because the generate code is copied to other address during booting, >>> so I underst

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-26 Thread Ming Lei
On Fri, Oct 25, 2013 at 7:58 PM, Rusty Russell wrote: >> >> Basically these symbols are only used to generate code, and in >> kernel mode, CPU won't run into the corresponding addresses >> because the generate code is copied to other address during booting, >> so I understand they won't appear in

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-25 Thread Rusty Russell
Ming Lei writes: > On Fri, Oct 25, 2013 at 1:50 PM, Rusty Russell wrote: >> Ming Lei writes: >>> On Fri, Oct 25, 2013 at 7:08 AM, Rusty Russell >>> wrote: Sorry, I was imprecise. I was referring to the kernel's kallsyms tables produced by scripts/kallsyms.c. This patch left th

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-25 Thread Ming Lei
On Fri, Oct 25, 2013 at 1:50 PM, Rusty Russell wrote: > Ming Lei writes: >> On Fri, Oct 25, 2013 at 7:08 AM, Rusty Russell wrote: >>> >>> Sorry, I was imprecise. I was referring to the kernel's kallsyms >>> tables produced by scripts/kallsyms.c. This patch left them in the >>> the kallsyms tab

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-24 Thread Rusty Russell
Ming Lei writes: > On Fri, Oct 25, 2013 at 7:08 AM, Rusty Russell wrote: >> >> Sorry, I was imprecise. I was referring to the kernel's kallsyms >> tables produced by scripts/kallsyms.c. This patch left them in the >> the kallsyms tables and filtered them out from /proc/kallsyms. > > Yes, but it

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-24 Thread Ming Lei
On Fri, Oct 25, 2013 at 7:08 AM, Rusty Russell wrote: > > Sorry, I was imprecise. I was referring to the kernel's kallsyms > tables produced by scripts/kallsyms.c. This patch left them in the > the kallsyms tables and filtered them out from /proc/kallsyms. Yes, but it isn't easy to do it by scr

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-24 Thread Rusty Russell
Russell King - ARM Linux writes: > On Thu, Oct 24, 2013 at 11:51:18AM +1030, Rusty Russell wrote: >> Ming Lei writes: >> > Address of non-module kernel symbol should always be located >> > from CONFIG_PAGE_OFFSET on, so only show these legal kernel >> > symbols in /proc/kallsyms. >> > >> > On ARM

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-24 Thread Ming Lei
On Thu, Oct 24, 2013 at 4:45 PM, Russell King - ARM Linux wrote: > On Thu, Oct 24, 2013 at 11:51:18AM +1030, Rusty Russell wrote: >> Ming Lei writes: >> > Address of non-module kernel symbol should always be located >> > from CONFIG_PAGE_OFFSET on, so only show these legal kernel >> > symbols in

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-24 Thread Russell King - ARM Linux
On Thu, Oct 24, 2013 at 11:51:18AM +1030, Rusty Russell wrote: > Ming Lei writes: > > Address of non-module kernel symbol should always be located > > from CONFIG_PAGE_OFFSET on, so only show these legal kernel > > symbols in /proc/kallsyms. > > > > On ARM, some symbols(see below) may drop in relo

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-23 Thread Ming Lei
On Thu, Oct 24, 2013 at 9:21 AM, Rusty Russell wrote: > Ming Lei writes: >> Address of non-module kernel symbol should always be located >> from CONFIG_PAGE_OFFSET on, so only show these legal kernel >> symbols in /proc/kallsyms. >> >> On ARM, some symbols(see below) may drop in relocatable code,

Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol

2013-10-23 Thread Rusty Russell
Ming Lei writes: > Address of non-module kernel symbol should always be located > from CONFIG_PAGE_OFFSET on, so only show these legal kernel > symbols in /proc/kallsyms. > > On ARM, some symbols(see below) may drop in relocatable code, so > perf can't parse kernel symbols any more from /proc/kall