Re: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver

2016-05-11 Thread Lee Jones
On Wed, 11 May 2016, Masahiro Yamada wrote: > Hi Lee, > > 2016-05-10 20:26 GMT+09:00 Lee Jones : > >> +}; > >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match); > > > > NACK. Please do not mix MFD and DT registration. > > OK, thanks for review. > > > My basic thought was: > > - Add an MFD node

Re: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver

2016-05-10 Thread Masahiro Yamada
Hi Lee, 2016-05-10 20:26 GMT+09:00 Lee Jones : >> +}; >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match); > > NACK. Please do not mix MFD and DT registration. OK, thanks for review. My basic thought was: - Add an MFD node to my DTS only once. If I need to expand it in the future, I will ju

Re: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver

2016-05-10 Thread Lee Jones
On Tue, 10 May 2016, Masahiro Yamada wrote: > This MFD driver populates child devices such clock, reset, and other > system controlling blocks. > > On UniPhier SoCs, one system control block contains various registers > for clock, reset, and others in it. So, it is not reasonable to have > separ