Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-19 Thread Jens Wiklander
Hi Arnd, On Fri, Apr 17, 2015 at 10:07:02PM +0200, Arnd Bergmann wrote: > On Friday 17 April 2015 09:50:56 Jens Wiklander wrote: > > Documentation/ioctl/ioctl-number.txt | 1 + > > drivers/Kconfig | 2 + > > drivers/Makefile | 1 + > > drivers/tee/Kc

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-19 Thread Greg Kroah-Hartman
On Sat, Apr 18, 2015 at 09:50:19PM +0100, Russell King - ARM Linux wrote: > On Sat, Apr 18, 2015 at 10:37:16PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Apr 18, 2015 at 08:02:24PM +0100, Russell King - ARM Linux wrote: > > > On Sat, Apr 18, 2015 at 08:47:13PM +0200, Greg Kroah-Hartman wrote: > >

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Russell King - ARM Linux
On Sat, Apr 18, 2015 at 10:37:16PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 18, 2015 at 08:02:24PM +0100, Russell King - ARM Linux wrote: > > On Sat, Apr 18, 2015 at 08:47:13PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Apr 18, 2015 at 10:04:20AM +0100, Russell King - ARM Linux wrote: > >

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Greg Kroah-Hartman
On Sat, Apr 18, 2015 at 08:02:24PM +0100, Russell King - ARM Linux wrote: > On Sat, Apr 18, 2015 at 08:47:13PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Apr 18, 2015 at 10:04:20AM +0100, Russell King - ARM Linux wrote: > > > On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > >

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Russell King - ARM Linux
On Sat, Apr 18, 2015 at 08:47:13PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 18, 2015 at 10:04:20AM +0100, Russell King - ARM Linux wrote: > > On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > > > +stru

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Greg Kroah-Hartman
On Sat, Apr 18, 2015 at 10:04:20AM +0100, Russell King - ARM Linux wrote: > On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > > +struct tee_device { > > > + char name[TEE_MAX_DEV_NAME_LEN]; > > > + const struc

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Russell King - ARM Linux
On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote: > On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > > +struct tee_device { > > + char name[TEE_MAX_DEV_NAME_LEN]; > > + const struct tee_desc *desc; > > + struct device *dev; > > No, please embed the device i

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Greg Kroah-Hartman
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > +struct tee_device { > + char name[TEE_MAX_DEV_NAME_LEN]; > + const struct tee_desc *desc; > + struct device *dev; No, please embed the device in your structure, don't have a pointer to it. > + struct miscdevice mis

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Greg Kroah-Hartman
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > +/** > + * struct tee_cmd_data - Opaque command argument > + * @buf_ptr: [in] A __user pointer to a command buffer > + * @buf_len: [in] Length of the buffer above > + * > + * Opaque command data which is passed on to the specific dri

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-18 Thread Paul Bolle
On Fri, 2015-04-17 at 22:07 +0200, Arnd Bergmann wrote: > On Friday 17 April 2015 09:50:56 Jens Wiklander wrote: > > +static const struct file_operations tee_fops = { > > + .owner = THIS_MODULE, > > + .open = tee_open, > > + .release = tee_release, > > + .unlocked_ioctl = tee_ioctl > > +};

Re: [RFC PATCH 1/2] tee: generic TEE subsystem

2015-04-17 Thread Arnd Bergmann
On Friday 17 April 2015 09:50:56 Jens Wiklander wrote: > Documentation/ioctl/ioctl-number.txt | 1 + > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/tee/Kconfig | 8 + > drivers/tee/Makefile | 3 + > d