Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Rob Herring
On Thu, Jan 21, 2021 at 4:38 AM Arnd Bergmann wrote: > > On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij > wrote: > > > > Hi Mohamed, > > > > thanks for your patch! > > > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > > wrote: > > > > > +properties: > > > + compatible: > > > +items: >

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Rob Herring
On Thu, Jan 21, 2021 at 9:31 AM Hector Martin 'marcan' wrote: > > On 21/01/2021 19.37, Arnd Bergmann wrote: > > On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij > > wrote: > >> > >> However weird it may seem, Apple is not in the file > >> Documentation/devicetree/bindings/vendor-prefixes.yaml > >

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Hector Martin 'marcan'
On 20/01/2021 22.27, Mohamed Mediouni wrote: + irq_domain_set_info(d, virq, hw, &apple_aic_irq_chip, + d->host_data, handle_level_irq, NULL, NULL); The AIC automatically masks IRQs on reason fetch, which means the handle_level_irq flow is redunda

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Rob Herring
On Thu, Jan 21, 2021 at 3:49 AM Linus Walleij wrote: > > Hi Mohamed, > > thanks for your patch! > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > wrote: > > > +properties: > > + compatible: > > +items: > > + - const: apple,aic As mentioned in patch 7, this needs to be SoC specific

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Hector Martin 'marcan'
On 21/01/2021 19.37, Arnd Bergmann wrote: On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: However weird it may seem, Apple is not in the file Documentation/devicetree/bindings/vendor-prefixes.yaml Since Apple are already using both the "AAPL" and the "apple" prefix themselves, I have a

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Arnd Bergmann
On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: > > Hi Mohamed, > > thanks for your patch! > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > wrote: > > > +properties: > > + compatible: > > +items: > > + - const: apple,aic > > However weird it may seem, Apple is not in the fil

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-21 Thread Linus Walleij
Hi Mohamed, thanks for your patch! On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni wrote: > +properties: > + compatible: > +items: > + - const: apple,aic However weird it may seem, Apple is not in the file Documentation/devicetree/bindings/vendor-prefixes.yaml (I think it's weird b

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-20 Thread Stan Skowronek
Acked-by: Stan Skowronek On 1/20/21 8:27 AM, Mohamed Mediouni wrote: From: Stan Skowronek Apple SoCs use the Apple AIC interrupt controller. The Arm architectural timers is wired over FIQ on that hardware. Signed-off-by: Stan Skowronek Signed-off-by: Mohamed Mediouni --- .../interrupt-co

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-20 Thread Andrew Lunn
> >> @@ -1218,6 +1218,12 @@ T: git > >> git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor > >> F:Documentation/admin-guide/LSM/apparmor.rst > >> F:security/apparmor/ > >> +APPLE ADVANCED INTERRUPT CONTROLLER DRIVER > >> +M:Stan Skowronek > > > > Signing s

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-20 Thread Mohamed Mediouni
> On 20 Jan 2021, at 18:11, Alexander Graf wrote: > > On 20.01.21 14:27, Mohamed Mediouni wrote: >> From: Stan Skowronek >> Apple SoCs use the Apple AIC interrupt controller. >> The Arm architectural timers is wired over FIQ on that hardware. >> Signed-off-by: Stan Skowronek >> Signed-off-by

Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC

2021-01-20 Thread Alexander Graf
On 20.01.21 14:27, Mohamed Mediouni wrote: From: Stan Skowronek Apple SoCs use the Apple AIC interrupt controller. The Arm architectural timers is wired over FIQ on that hardware. Signed-off-by: Stan Skowronek Signed-off-by: Mohamed Mediouni --- .../interrupt-controller/apple,aic.yaml