Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-22 Thread J. Bruce Fields
On Wed, Sep 23, 2015 at 03:39:44AM +0200, Andreas Gruenbacher wrote: > Here are my improvements; hope that helps ... Yes, looks good, thanks!--b. > > Thanks, > Andreas > > diff --git a/fs/richacl_compat.c b/fs/richacl_compat.c > index 9b76fc0..21af9a0 100644 > --- a/fs/richacl_compat.c > +++ b/

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-22 Thread Andreas Gruenbacher
Here are my improvements; hope that helps ... Thanks, Andreas diff --git a/fs/richacl_compat.c b/fs/richacl_compat.c index 9b76fc0..21af9a0 100644 --- a/fs/richacl_compat.c +++ b/fs/richacl_compat.c @@ -351,26 +351,26 @@ richacl_propagate_everyone(struct richacl_alloc *alloc) struct richa

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-22 Thread Andreas Gruenbacher
2015-09-21 21:24 GMT+02:00 J. Bruce Fields : > On Fri, Sep 18, 2015 at 05:56:11PM -0400, bfields wrote: >> On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: >> > + /* >> > +* If the owner mask contains permissions which are not in the group >> > +* mask, the group mask

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-21 Thread Andreas Gruenbacher
2015-09-18 23:36 GMT+02:00 J. Bruce Fields : > On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: >> + if (!richace_is_owner(who) && >> + richace_is_everyone(ace) && richace_is_allow(ace) && > > That richace_is_allow(ace) check is redundant at this point, isn't it? Ye

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-21 Thread J. Bruce Fields
On Fri, Sep 18, 2015 at 05:56:11PM -0400, bfields wrote: > On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: > > The trailing everyone@ allow ace can grant permissions to all file > > classes including the owner and group class. Before we can apply the > > other mask to this ent

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-18 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: > The trailing everyone@ allow ace can grant permissions to all file > classes including the owner and group class. Before we can apply the > other mask to this entry to turn it into an "other class" entry, we need > to ensure th

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-18 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: > The trailing everyone@ allow ace can grant permissions to all file > classes including the owner and group class. Before we can apply the > other mask to this entry to turn it into an "other class" entry, we need > to ensure th