Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-27 Thread Thomas Gleixner
On Thu, 27 Feb 2014, Haojian Zhuang wrote: > Let me list the logic to make it easier to understand. > > suspend_enter() > --> dpm_suspend_end() >--> dpm_suspend_noirq() > --> suspend_device_irqs() > --> __disable_irq() >

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-26 Thread Haojian Zhuang
On Thu, Feb 27, 2014 at 9:37 AM, Chao Xie wrote: > On Mon, Feb 24, 2014 at 7:31 PM, Thomas Gleixner wrote: >> On Mon, 24 Feb 2014, Haojian Zhuang wrote: >> >>> On Mon, Feb 24, 2014 at 2:07 PM, Chao Xie wrote: >>> > On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König >>> > wrote: >>> >> Hi Thomas,

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-26 Thread Chao Xie
On Mon, Feb 24, 2014 at 7:31 PM, Thomas Gleixner wrote: > On Mon, 24 Feb 2014, Haojian Zhuang wrote: > >> On Mon, Feb 24, 2014 at 2:07 PM, Chao Xie wrote: >> > On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König >> > wrote: >> >> Hi Thomas, >> >> >> >> On Sun, Feb 23, 2014 at 09:40:13PM -, Tho

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-24 Thread Thomas Gleixner
On Mon, 24 Feb 2014, Haojian Zhuang wrote: > On Mon, Feb 24, 2014 at 2:07 PM, Chao Xie wrote: > > On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König > > wrote: > >> Hi Thomas, > >> > >> On Sun, Feb 23, 2014 at 09:40:13PM -, Thomas Gleixner wrote: > >>> The pm-mmp2 and pm-pxa910 power manageme

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-24 Thread Thomas Gleixner
On Mon, 24 Feb 2014, Chao Xie wrote: > On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König > wrote: > > Hi Thomas, > > > > On Sun, Feb 23, 2014 at 09:40:13PM -, Thomas Gleixner wrote: > >> The pm-mmp2 and pm-pxa910 power management related irq_set_wake > >> callbacks fiddle pointlessly with the

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-23 Thread Haojian Zhuang
On Mon, Feb 24, 2014 at 2:07 PM, Chao Xie wrote: > On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König > wrote: >> Hi Thomas, >> >> On Sun, Feb 23, 2014 at 09:40:13PM -, Thomas Gleixner wrote: >>> The pm-mmp2 and pm-pxa910 power management related irq_set_wake >>> callbacks fiddle pointlessly w

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-23 Thread Chao Xie
On Mon, Feb 24, 2014 at 7:17 AM, Uwe Kleine-König wrote: > Hi Thomas, > > On Sun, Feb 23, 2014 at 09:40:13PM -, Thomas Gleixner wrote: >> The pm-mmp2 and pm-pxa910 power management related irq_set_wake >> callbacks fiddle pointlessly with the irq actions for no reason except >> for lack of und

Re: [patch 09/26] arm: mmp: Remove pointless fiddling with irq internals

2014-02-23 Thread Uwe Kleine-König
Hi Thomas, On Sun, Feb 23, 2014 at 09:40:13PM -, Thomas Gleixner wrote: > The pm-mmp2 and pm-pxa910 power management related irq_set_wake > callbacks fiddle pointlessly with the irq actions for no reason except > for lack of understanding how the wakeup mechanism works. > > On supsend the cor