Hi Thomas, On Sun, Feb 23, 2014 at 09:40:13PM -0000, Thomas Gleixner wrote: > The pm-mmp2 and pm-pxa910 power management related irq_set_wake > callbacks fiddle pointlessly with the irq actions for no reason except > for lack of understanding how the wakeup mechanism works. > > On supsend the core disables all interrupts lazily, i.e. it does not > mask them at the irq controller level. So any interrupt which is > firing during supsend will mark the corresponding interrupt line as s/supsend/suspend/ twice > pending. Just before the core powers down it checks whether there are > interrupts pending from interrupt lines which are marked as wakeup > sources and if so it aborts the resume and resends the interrupts. It's the suspend that is aborted, not the resume.
Other than that your change looks fine. Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
