Re: Patch to make ymfpci legacy address 16 bits

2001-05-10 Thread mirabilos
> When you write "the kernel", do you mean the driver or generic > code? I hope you mean the driver, because I have this: > > 1. the device looks normal at power on > 2. the driver pokes a device-specific config register > 3. the config space header changes from type 0 to type 1 > > (The class c

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Albert D. Cahalan
Jeff Garzik writes: > Pavel Roskin wrote: >> You may need to save some data in memory when the system goes >> to suspend and restore them afterwards. I believe that the PCI >> config space should be saved by BIOS. Everything else is the >> responsibility of the driver. > > In ACPI land the kernel

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Zach Brown
On Wed, May 09, 2001 at 05:08:15PM -0400, Jeff Garzik wrote: > Why does maestro.c not use my suggestion? Because it doesn't use struct > pci_driver. I finally found an able hacker with maestro hardware with power management. He not only fixed the nasty pm races that were causing channel corrup

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Pavel Roskin
Hi, Jeff! > Basically the PCI core should implement what PM is necessary, because > eventually struct pci_driver will become a more generic struct driver. I just wanted to make sure that you don't expect any problems if we go this way. > Why does maestro.c not use my suggestion? Because it doe

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Jeff Garzik
Pavel Roskin wrote: > > Hi, Jeff! > > Thanks for your very (!!!) fast response :-) > > > > http://www.red-bean.com/~proski/linux/ymfpci_pm.diff > > > > Why not use pci_driver::{suspend,resume} ? > > I'm just a bit conservative. There are several drivers that don't use this > mechanism, notably

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Pavel Roskin
Hi, Jeff! Thanks for your very (!!!) fast response :-) > > http://www.red-bean.com/~proski/linux/ymfpci_pm.diff > > Why not use pci_driver::{suspend,resume} ? I'm just a bit conservative. There are several drivers that don't use this mechanism, notably trident and maestro. Do you think it's saf

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Jeff Garzik
Pavel Roskin wrote: > If you want to play further with APM and ymfpci, I made a stub for proper > apm support in the ymfpci driver. It's available here: > > http://www.red-bean.com/~proski/linux/ymfpci_pm.diff Why not use pci_driver::{suspend,resume} ? > You may need to save some data in memor

Re: Patch to make ymfpci legacy address 16 bits

2001-05-09 Thread Pavel Roskin
Hi, Pete! Next time you are asking my opinion please cc: me, so that I can quote you. Yes, I think you have fixed a terrible bug in ymfpci. Decoding only 10-bit addresses is extremely dangerous, considering that only 388-38b is reserved, while 788-78b etc are not. In order to get your patch acc