Re: SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
On Sat, Nov 04, 2000 at 12:13:33PM +1100, Gareth Hughes wrote: > Yes, we can certainly mask out the mxcsr value in both cases. I just ^^^ s/can/must/ > think this makes the code a lot simpler and cleaner as a result - three I agree about the three vs one copy issue. Anyways my first

Re: SETFPXREGS fix

2000-11-03 Thread Gareth Hughes
Andrea Arcangeli wrote: > > On Sat, Nov 04, 2000 at 10:50:00AM +1100, Gareth Hughes wrote: > > if ( HAVE_FXSR ) { > > if ( __copy_from_user( >thread.i387.fxsave, (void *)buf, > > sizeof(struct user_fxsr_struct) ) ) > >

Re: SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
On Sat, Nov 04, 2000 at 10:50:00AM +1100, Gareth Hughes wrote: > if ( HAVE_FXSR ) { > if ( __copy_from_user( >thread.i387.fxsave, (void *)buf, > sizeof(struct user_fxsr_struct) ) ) > return -EFAULT; > /*

Re: SETFPXREGS fix

2000-11-03 Thread Gareth Hughes
Andrea Arcangeli wrote: > > --- 2.4.0-test10/arch/i386/kernel/i387.cThu Nov 2 20:58:58 2000 > +++ PIII/arch/i386/kernel/i387.cThu Nov 2 18:44:36 2000 > @@ -440,8 +436,25 @@ > int set_fpxregs( struct task_struct *tsk, struct user_fxsr_struct *buf ) > { > if ( HAVE_FXSR

SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
n -EIO; Downloadable also from here: ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.0-test10/SETFPXREGS-fix-1 Users of 2.2.18pre17aa1 running their kernel on a PIII cpu are affected as well. Workaround is to boot with the `nofxsr' parameter (with the downside that

SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
//ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.0-test10/SETFPXREGS-fix-1 Users of 2.2.18pre17aa1 running their kernel on a PIII cpu are affected as well. Workaround is to boot with the `nofxsr' parameter (with the downside that PIII instructions to be inibithed like in vanil

Re: SETFPXREGS fix

2000-11-03 Thread Gareth Hughes
Andrea Arcangeli wrote: --- 2.4.0-test10/arch/i386/kernel/i387.cThu Nov 2 20:58:58 2000 +++ PIII/arch/i386/kernel/i387.cThu Nov 2 18:44:36 2000 @@ -440,8 +436,25 @@ int set_fpxregs( struct task_struct *tsk, struct user_fxsr_struct *buf ) { if ( HAVE_FXSR ) { -

Re: SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
On Sat, Nov 04, 2000 at 10:50:00AM +1100, Gareth Hughes wrote: if ( HAVE_FXSR ) { if ( __copy_from_user( tsk-thread.i387.fxsave, (void *)buf, sizeof(struct user_fxsr_struct) ) ) return -EFAULT; /*

Re: SETFPXREGS fix

2000-11-03 Thread Gareth Hughes
Andrea Arcangeli wrote: On Sat, Nov 04, 2000 at 10:50:00AM +1100, Gareth Hughes wrote: if ( HAVE_FXSR ) { if ( __copy_from_user( tsk-thread.i387.fxsave, (void *)buf, sizeof(struct user_fxsr_struct) ) )

Re: SETFPXREGS fix

2000-11-03 Thread Andrea Arcangeli
On Sat, Nov 04, 2000 at 12:13:33PM +1100, Gareth Hughes wrote: Yes, we can certainly mask out the mxcsr value in both cases. I just ^^^ s/can/must/ think this makes the code a lot simpler and cleaner as a result - three I agree about the three vs one copy issue. Anyways my first