[PATCH v1] bluetooth: hci_qca: Fix suspend/resume functionality failure

2020-05-28 Thread Zijun Hu
@dev parameter of qca_suspend()/qca_resume() represents serdev_device, but it is mistook for hci_dev and causes succedent unexpected memory access. Fix by taking @dev as serdev_device. Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 12 1 file changed, 8 insertions(+), 4

RE: [PATCH] mailbox: imx: Add context save/restore for suspend/resume

2020-05-27 Thread Anson Huang
Gentle ping... > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > suspend/resume > > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > suspend/resume > > > > > From: Anson Huang > > > Sent: Friday

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-25 Thread Mark Brown
On Fri, 22 May 2020 17:57:24 +0800, Shengjiu Wang wrote: > With dedicated power domain for asrc, power can be disabled after > probe and pm runtime suspend, then the value of all registers need to > be restored in pm runtime resume. So we can merge suspend/resume function > to run

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Marek Szyprowski
g the >>> i2c_client. >> Just one more comment. The devices without i2c_client structure are the >> i2c 'devices' associated with the respective i2c bus. They are visible >> in /sys: >> >> ls -l /sys/bus/i2c/devices/i2c-* >> >> I wonder if t

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-25 Thread Tomasz Figa
e more comment. The devices without i2c_client structure are the > i2c 'devices' associated with the respective i2c bus. They are visible > in /sys: > > ls -l /sys/bus/i2c/devices/i2c-* > > I wonder if this patch has been ever tested with system suspend/resume, > as thos

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 10:18:16AM +0200, Nicolas Ferre wrote: > On 07/05/2020 at 12:03, Nicolas Ferre wrote: > > On 06/05/2020 at 22:18, Jakub Kicinski wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Wed, 6 May 2020 13:

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-25 Thread Nicolas Ferre
On 07/05/2020 at 12:03, Nicolas Ferre wrote: On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper struc

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-24 Thread Nicolin Chen
On Mon, May 25, 2020 at 02:11:18PM +0800, Shengjiu Wang wrote: > > > @@ -1135,6 +1137,24 @@ static int fsl_asrc_runtime_resume(struct device > > > *dev) > > > goto disable_asrck_clk; > > > } > > > > > > + /* Stop all pairs provisionally */ > > > + regmap_read(as

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-24 Thread Nicolin Chen
On Fri, May 22, 2020 at 05:57:24PM +0800, Shengjiu Wang wrote: > With dedicated power domain for asrc, power can be disabled after > probe and pm runtime suspend, then the value of all registers need to > be restored in pm runtime resume. So we can merge suspend/resume func

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-24 Thread Shengjiu Wang
e restored in pm runtime resume. So we can merge suspend/resume function > > to runtime_suspend/resume function and enable regcache only in end of > > probe. > > > > Signed-off-by: Shengjiu Wang > > --- > > sound/soc/fsl/fsl_asrc.c | 70 --

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-24 Thread Nicolin Chen
On Fri, May 22, 2020 at 05:57:24PM +0800, Shengjiu Wang wrote: > With dedicated power domain for asrc, power can be disabled after > probe and pm runtime suspend, then the value of all registers need to > be restored in pm runtime resume. So we can merge suspend/resume func

Re: [RESEND PATCH] thermal: mediatek: add suspend/resume callback

2020-05-22 Thread Daniel Lezcano
On 08/04/2020 11:05, Michael Kao wrote: > From: Louis Yu > > Add suspend/resume callback to disable/enable Mediatek thermal sensor > respectively. Since thermal power domain is off in suspend, thermal driver > needs re-initialization during resume. > > Signed-off-by: Loui

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-22 Thread Wolfram Sang
ore comment. The devices without i2c_client structure are the > i2c 'devices' associated with the respective i2c bus. They are visible > in /sys: > > ls -l /sys/bus/i2c/devices/i2c-* > > I wonder if this patch has been ever tested with system suspend/resume, > as

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-22 Thread Marek Szyprowski
They are visible in /sys: ls -l /sys/bus/i2c/devices/i2c-* I wonder if this patch has been ever tested with system suspend/resume, as those devices are always available in the system... > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

[PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-22 Thread Marek Szyprowski
apter") Signed-off-by: Marek Szyprowski --- This fixes suspend/resume issue observed on various board with linux-next from 20200521. --- drivers/i2c/i2c-core-base.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/driv

[PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-22 Thread Shengjiu Wang
With dedicated power domain for asrc, power can be disabled after probe and pm runtime suspend, then the value of all registers need to be restored in pm runtime resume. So we can merge suspend/resume function to runtime_suspend/resume function and enable regcache only in end of probe. Signed-off

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Agarwal, Anchal
Thanks. Looks like send an old one without fix. Did resend the patch again. On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Singh, Balbir
On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

[PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Anchal Agarwal
t all interrupts connected to it are handled this way. This is pretty much in line with the other interrupt chip specific quirks, e.g. IRQCHIP_MASK_ON_SUSPEND. Add a new quirk flag IRQCHIP_SHUTDOWN_ON_SUSPEND and add support for it the core interrupt suspend/resume paths. Signed-off-by: Anchal Agarwal S

[PATCH 5.6 165/194] usb: gadget: tegra-xudc: Fix idle suspend/resume

2020-05-18 Thread Greg Kroah-Hartman
From: Thierry Reding commit 0534d40160cb9505073b0ecf5e7210daee319a66 upstream. When the XUDC device is idle (i.e. powergated), care must be taken not to access any registers because that would lead to a crash. Move the call to tegra_xudc_device_mode_off() into the same conditional as the tegra_

Re: [PATCH net-next 0/2] net: ipa: sc7180 suspend/resume

2020-05-16 Thread David Miller
From: Alex Elder Date: Fri, 15 May 2020 15:07:29 -0500 > This series permits suspend/resume to work for the IPA driver > on the Qualcomm SC7180 SoC. The IPA version on this SoC requires > interrupts to be enabled when the suspend and resume callbacks are > made, and the first patc

[PATCH net-next 0/2] net: ipa: sc7180 suspend/resume

2020-05-15 Thread Alex Elder
This series permits suspend/resume to work for the IPA driver on the Qualcomm SC7180 SoC. The IPA version on this SoC requires interrupts to be enabled when the suspend and resume callbacks are made, and the first patch moves away from using the noirq variants. The second patch fixes a problem

[PATCH net-next 1/2] net: ipa: don't use noirq suspend/resume callbacks

2020-05-15 Thread Alex Elder
Use the suspend and resume callbacks rather than suspend_noirq and resume_noirq. With IPA v4.2, we use the CHANNEL_STOP command to implement a suspend, and without interrupts enabled, that command won't complete. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 4 ++-- 1 file changed,

Re: [PATCH] mmc: sdhci-of-dwcmshc: add suspend/resume support

2020-05-15 Thread Ulf Hansson
On Fri, 15 May 2020 at 08:19, Jisheng Zhang wrote: > > Add dwcmshc specific system-level suspend and resume support. > > Signed-off-by: Jisheng Zhang Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-dwcmshc.c | 43 + > 1 file changed,

[PATCH] mmc: sdhci-of-dwcmshc: add suspend/resume support

2020-05-14 Thread Jisheng Zhang
Add dwcmshc specific system-level suspend and resume support. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-of-dwcmshc.c | 43 + 1 file changed, 43 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c index a

[PATCH 7/7] pinctrl: realtek: DHC: Add suspend/resume callback function.

2020-05-14 Thread TY Chang
Add suspend and resume callback function for Realtek DHC SoC pinctrl driver. Signed-off-by: TY Chang --- drivers/pinctrl/realtek/pinctrl-rtd.c | 39 + drivers/pinctrl/realtek/pinctrl-rtd1195.h | 33 +++ drivers/pinctrl/realtek/pinctrl-rtd1295.h | 67 ++

Re: [RESEND PATCH] thermal: mediatek: add suspend/resume callback

2020-05-14 Thread Michael Kao
On Wed, 2020-04-08 at 17:05 +0800, Michael Kao (高振翔) wrote: > From: Louis Yu > > Add suspend/resume callback to disable/enable Mediatek thermal sensor > respectively. Since thermal power domain is off in suspend, thermal driver > needs re-initialization during resume. > >

Re: [PATCH] x86/hyperv: Properly suspend/resume reenlightenment notifications

2020-05-13 Thread Wei Liu
On Tue, May 12, 2020 at 06:01:53PM +0200, Vitaly Kuznetsov wrote: > Errors during hibernation with reenlightenment notifications enabled were > reported: > > [ 51.730435] PM: hibernation entry > [ 51.737435] PM: Syncing filesystems ... > ... > [ 54.102216] Disabling non-boot CPUs ... >

Re: [PATCH] x86/hyperv: Properly suspend/resume reenlightenment notifications

2020-05-13 Thread Tianyu Lan
On 5/13/2020 12:01 AM, Vitaly Kuznetsov wrote: Errors during hibernation with reenlightenment notifications enabled were reported: [ 51.730435] PM: hibernation entry [ 51.737435] PM: Syncing filesystems ... ... [ 54.102216] Disabling non-boot CPUs ... [ 54.106633] smpboot: CPU

RE: [PATCH] x86/hyperv: Properly suspend/resume reenlightenment notifications

2020-05-12 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Tuesday, May 12, 2020 9:02 AM > To: linux-hyp...@vger.kernel.org > Cc: Wei Liu ; x...@kernel.org; > linux-kernel@vger.kernel.org; k...@vger.kernel.org; Michael Kelley > ; Dexuan Cui ; Tianyu Lan > > Subject: [PATCH] x86/hyperv:

[PATCH] x86/hyperv: Properly suspend/resume reenlightenment notifications

2020-05-12 Thread Vitaly Kuznetsov
Errors during hibernation with reenlightenment notifications enabled were reported: [ 51.730435] PM: hibernation entry [ 51.737435] PM: Syncing filesystems ... ... [ 54.102216] Disabling non-boot CPUs ... [ 54.106633] smpboot: CPU 1 is now offline [ 54.110006] unchecked MSR access

[RFC 15/17] Revert "drm/amdgpu: add fbdev suspend/resume on gpu reset"

2020-05-12 Thread Daniel Vetter
This is one from the department of "maybe play lottery if you hit this, karma compensation might work". Or at least lockdep ftw! This reverts commit 565d1941557756a584ac357d945bc374d5fcd1d0. It's not quite as low-risk as the commit message claims, because this grabs console_lock, which might be h

[PATCH v11 15/56] Input: atmel_mxt_ts - report failures in suspend/resume

2020-05-07 Thread Jiada Wang
From: Nick Dyer This patch reports failures in suspend/resume Signed-off-by: Nick Dyer (cherry picked from ndyer/linux/for-upstream commit 93a57575403d) [gdavis: Resolve forward port conflicts due to applying upstream commit 96a938aa214e ("Input: atmel_mxt_ts - remove pla

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-07 Thread Nicolas Ferre
On 06/05/2020 at 22:18, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag a

Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 13:37:37 +0200 nicolas.fe...@microchip.com wrote: > From: Nicolas Ferre > > Use the proper struct device pointer to check if the wakeup flag > and wakeup source are positioned. > Use the one passed by function call which is equivalent to > &bp->dev->dev.parent. > > It's preven

Re: [PATCH] usb: gadget: tegra-xudc: Fix idle suspend/resume

2020-05-06 Thread Thierry Reding
On Fri, Apr 17, 2020 at 07:05:37PM +0200, Thierry Reding wrote: > From: Thierry Reding > > When the XUDC device is idle (i.e. powergated), care must be taken not > to access any registers because that would lead to a crash. > > Move the call to tegra_xudc_device_mode_off() into the same conditio

[PATCH v4 5/5] net: macb: fix call to pm_runtime in the suspend/resume functions

2020-05-06 Thread nicolas.ferre
From: Nicolas Ferre The calls to pm_runtime_force_suspend/resume() functions are only relevant if the device is not configured to act as a WoL wakeup source. Add the device_may_wakeup() test before calling them. Fixes: 3e2a5e153906 ("net: macb: add wake-on-lan support via magic packet") Signed-o

[PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-06 Thread nicolas.ferre
From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag and wakeup source are positioned. Use the one passed by function call which is equivalent to &bp->dev->dev.parent. It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan feature is used. Fi

[PATCH 5.6 29/73] x86/hyperv: Suspend/resume the VP assist page for hibernation

2020-05-04 Thread Greg Kroah-Hartman
there is any active L2 guest. Fixes: 05bd330a7fd8 ("x86/hyperv: Suspend/resume the hypercall page for hibernation") Cc: sta...@vger.kernel.org Signed-off-by: Dexuan Cui Link: https://lore.kernel.org/r/1587437171-2472-1-git-send-email-de...@microsoft.com Signed-off-by: Wei Liu Signed-off-

[PATCH v3 5/7] net: macb: fix call to pm_runtime in the suspend/resume functions

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre The calls to pm_runtime_force_suspend/resume() functions are only relevant if the device is not configured to act as a WoL wakeup source. Add the device_may_wakeup() test before calling them. Fixes: 3e2a5e153906 ("net: macb: add wake-on-lan support via magic packet") Cc: Clau

[PATCH v3 1/7] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag and wakeup source are positioned. Use the one passed by function call which is equivalent to &bp->dev->dev.parent. It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan feature is used. Fi

[PATCH 5.6 022/106] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-05-01 Thread Greg Kroah-Hartman
From: Shengjiu Wang commit 1e060a453c8604311fb45ae2f84f67ed673329b4 upstream. After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock rate

[PATCH 5.6 019/106] ASoC: samsung: s3c24xx-i2s: Fix build after removal of DAI suspend/resume

2020-05-01 Thread Greg Kroah-Hartman
From: Krzysztof Kozlowski commit ec21bdc6dd16d74b3674ef1fd12ae8e4e7418603 upstream. Commit 450312b640f9 ("ASoC: soc-core: remove DAI suspend/resume") removed the DAI side suspend/resume hooks and switched entirely to component suspend/resume. However the Samsung SoC s3c-i2s-v2 driv

[PATCH 5.4 18/83] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-05-01 Thread Greg Kroah-Hartman
From: Shengjiu Wang commit 1e060a453c8604311fb45ae2f84f67ed673329b4 upstream. After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock rate

[PATCH 4.19 10/46] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-05-01 Thread Greg Kroah-Hartman
From: Shengjiu Wang commit 1e060a453c8604311fb45ae2f84f67ed673329b4 upstream. After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock rate

[PATCH AUTOSEL 5.6 56/79] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-04-30 Thread Sasha Levin
From: Shengjiu Wang [ Upstream commit 1e060a453c8604311fb45ae2f84f67ed673329b4 ] After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock

[PATCH AUTOSEL 5.4 39/57] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-04-30 Thread Sasha Levin
From: Shengjiu Wang [ Upstream commit 1e060a453c8604311fb45ae2f84f67ed673329b4 ] After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock

[PATCH AUTOSEL 4.19 22/30] ASoC: wm8960: Fix wrong clock after suspend & resume

2020-04-30 Thread Sasha Levin
From: Shengjiu Wang [ Upstream commit 1e060a453c8604311fb45ae2f84f67ed673329b4 ] After suspend & resume, wm8960_hw_params may be called when bias_level is not SND_SOC_BIAS_ON, then wm8960_configure_clocking is not called. But if sample rate is changed at that time, then the output clock

[PATCH AUTOSEL 5.6 17/79] ASoC: samsung: s3c24xx-i2s: Fix build after removal of DAI suspend/resume

2020-04-30 Thread Sasha Levin
From: Krzysztof Kozlowski [ Upstream commit ec21bdc6dd16d74b3674ef1fd12ae8e4e7418603 ] Commit 450312b640f9 ("ASoC: soc-core: remove DAI suspend/resume") removed the DAI side suspend/resume hooks and switched entirely to component suspend/resume. However the Samsung SoC s3c-i2s-v2

Re: [v2, PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-16 Thread David Miller
From: Biao Huang Date: Tue, 15 Oct 2019 11:24:44 +0800 > disable ptp_ref_clk in suspend flow, and enable it in resume flow. > > Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and > stmmac_rst to platform structure") > Signed-off-by: Biao Huang Applied and queued up for -stab

[v2, PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-14 Thread Biao Huang
disable ptp_ref_clk in suspend flow, and enable it in resume flow. Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 1 file changed, 8 inserti

[v2, PATCH 0/1] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-14 Thread Biao Huang
changes in v2: 1. add Fixes in commit message 2. replace clk_disable/clk_enable with clk_disable_unprepare/clk_prepare_enable to ensure the source pll can be closed/open in suspend/resume for power saving. Biao Huang (1): net: stmmac: disable/enable ptp_ref_clk in

Re: [RESEND PATCH] thermal: mediatek: add suspend/resume callback

2019-10-13 Thread Daniel Lezcano
On 09/10/2019 11:35, michael@mediatek.com wrote: > From: Louis Yu > > Add suspend/resume callback to disable/enable Mediatek thermal sensor > respectively. Since thermal power domain is off in suspend, thermal driver > needs re-initialization during resume. > > Si

Re: [PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-11 Thread biao huang
Appreciate your comments! On Thu, 2019-10-10 at 16:01 -0700, Jakub Kicinski wrote: > On Wed, 9 Oct 2019 16:56:49 +0800, Biao Huang wrote: > > disable ptp_ref_clk in suspend flow, and enable it in resume flow. > > > > Signed-off-by: Biao Huang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmm

Re: [PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-10 Thread Jakub Kicinski
On Wed, 9 Oct 2019 16:56:49 +0800, Biao Huang wrote: > disable ptp_ref_clk in suspend flow, and enable it in resume flow. > > Signed-off-by: Biao Huang > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/stm

[RESEND PATCH] thermal: mediatek: add suspend/resume callback

2019-10-09 Thread michael.kao
From: Louis Yu Add suspend/resume callback to disable/enable Mediatek thermal sensor respectively. Since thermal power domain is off in suspend, thermal driver needs re-initialization during resume. Signed-off-by: Louis Yu Signed-off-by: Michael Kao --- This patch series base on these patches

[PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

2019-10-09 Thread Biao Huang
disable ptp_ref_clk in suspend flow, and enable it in resume flow. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmm

Re: [PATCH net] net: stmmac: Avoid deadlock on suspend/resume

2019-10-02 Thread David Miller
ated with the private mutex > held already, which causes a deadlock during suspend. > > Fix this by moving the phylink configuration updates out of the region > of code protected by the private mutex. > > Fixes: 19e13cb27b99 ("net: stmmac: Hold rtnl lock in suspend/resume

[PATCH net] net: stmmac: Avoid deadlock on suspend/resume

2019-10-02 Thread Thierry Reding
x this by moving the phylink configuration updates out of the region of code protected by the private mutex. Fixes: 19e13cb27b99 ("net: stmmac: Hold rtnl lock in suspend/resume callbacks") Suggested-by: Bitan Biswas Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/st

RE: [PATCH v5 1/3] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-30 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Friday, September 27, 2019 2:05 AM > To: Dexuan Cui > > Dexuan Cui writes: > ... > > So, I'm pretty sure no IPI can happen between hv_suspend() and > hv_resume(). > > self-IPI is not supposed to happen either, since interrupts are disabled. > > > > IMO TLB flush

RE: [PATCH v5 1/3] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-27 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> From: Vitaly Kuznetsov >> Sent: Thursday, September 26, 2019 3:44 AM >> > [...] >> > +static int hv_suspend(void) >> > +{ >> > + union hv_x64_msr_hypercall_contents hypercall_msr; >> > + >> > + /* Reset the hypercall page */ >> > + rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_

RE: [PATCH v5 1/3] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-26 Thread Dexuan Cui
> From: Vitaly Kuznetsov > Sent: Thursday, September 26, 2019 3:44 AM > > [...] > > +static int hv_suspend(void) > > +{ > > + union hv_x64_msr_hypercall_contents hypercall_msr; > > + > > + /* Reset the hypercall page */ > > + rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); > > + hyp

RE: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-26 Thread Dexuan Cui
> From: Daniel Lezcano > Sent: Thursday, September 26, 2019 6:17 AM > >> > >> I can take this patch if needed. > > > > Thanks, Daniel! Usually tglx takes care of the patches, but it looks > > recently he > > may be too busy to handle the 3 patches. > > > > I guess you can take the patch, if tglx

Re: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-26 Thread Daniel Lezcano
el@vger.kernel.org; mi...@redhat.com; sas...@kernel.org; Stephen >> Hemminger ; t...@linutronix.de; x...@kernel.org; >> Michael Kelley ; Sasha Levin >> >> Cc: linux-a...@vger.kernel.org >> Subject: Re: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V >>

Re: [PATCH v5 1/3] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-26 Thread Vitaly Kuznetsov
Dexuan Cui writes: > This is needed for hibernation, e.g. when we resume the old kernel, we need > to disable the "current" kernel's hypercall page and then resume the old > kernel's. > > Signed-off-by: Dexuan Cui > Reviewed-by: Michael Kelley > --- > arch/x86/hyperv/hv_init.c | 33 +++

RE: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-25 Thread Dexuan Cui
en > Hemminger ; t...@linutronix.de; x...@kernel.org; > Michael Kelley ; Sasha Levin > > Cc: linux-a...@vger.kernel.org > Subject: Re: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V > clocksource for hibernation > > On 06/09/2019 00:47, Dexuan Cui wrote: > &

Re: [PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-25 Thread Daniel Lezcano
On 06/09/2019 00:47, Dexuan Cui wrote: > This is needed for hibernation, e.g. when we resume the old kernel, we need > to disable the "current" kernel's TSC page and then resume the old kernel's. > > Signed-off-by: Dexuan Cui > Reviewed-by: Michael Kelley I can take this patch if needed. > ---

RE: [PATCH] net: stmmac: Fix ASSERT_RTNL() warning on suspend/resume

2019-09-25 Thread Loys Ollivier
On Tue 17 Sep 2019 at 10:12, Jose Abreu wrote: > From: Loys Ollivier > Date: Sep/17/2019, 11:02:36 (UTC+00:00) > >> rtnl_lock needs to be taken before calling phylink_start/stop to lock the >> network stack. >> Fix ASSERT_RTNL() warnings by protecting such calls with lock/unlock. >> >> Fixes: 7

[PATCH 2/2] brcmfmac: fix suspend/resume when power is cut off

2019-09-25 Thread Adrian Ratiu
brcmfmac assumed the wifi device always remains powered on and thus hardcoded the MMC_PM_KEEP_POWER flag expecting the wifi device to remain on even during suspend/resume cycles. This is not always the case, some appliances cut power to everything connected via SDIO for efficiency reasons and

[PATCH 5.3 10/21] net: stmmac: Hold rtnl lock in suspend/resume callbacks

2019-09-19 Thread Greg Kroah-Hartman
From: Jose Abreu [ Upstream commit 19e13cb27b998ff49f07e399b5871bfe5ba7e3f0 ] We need to hold rnl lock in suspend and resume callbacks because phylink requires it. Otherwise we will get a WARN() in suspend and resume. Also, move phylink start and stop callbacks to inside device's internal lock

[PATCH RFC 2/2] clk: meson: g12a: add suspend-resume hooks

2019-09-19 Thread Neil Armstrong
Add suspend and resume hooks used to refresh the CPU clock tree when resuming from suspend, in the case where the PSCI firmware alters the clock tree. In the Amlogic G12A suspend/resume case, the PSCI firmware will alter the Fixed PLL dyn tree when entering with the CPU clock from this same tree

RE: [PATCH] net: stmmac: Fix ASSERT_RTNL() warning on suspend/resume

2019-09-17 Thread Jose Abreu
From: Loys Ollivier Date: Sep/17/2019, 11:02:36 (UTC+00:00) > rtnl_lock needs to be taken before calling phylink_start/stop to lock the > network stack. > Fix ASSERT_RTNL() warnings by protecting such calls with lock/unlock. > > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove ph

[PATCH] net: stmmac: Fix ASSERT_RTNL() warning on suspend/resume

2019-09-17 Thread Loys Ollivier
rtnl_lock needs to be taken before calling phylink_start/stop to lock the network stack. Fix ASSERT_RTNL() warnings by protecting such calls with lock/unlock. Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") Signed-off-by: Loys Ollivier --- drivers/net/ethernet/stm

[PATCH v3 15/49] Input: atmel_mxt_ts - report failures in suspend/resume

2019-09-17 Thread Jiada Wang
From: Nick Dyer (cherry picked from ndyer/linux/for-upstream commit 93a57575403de4dd07cd64807d3c2ed7f2cca262) [gdavis: Resolve forward port conflicts due to applying upstream commit 96a938aa214e ("Input: atmel_mxt_ts - remove platform data support").] Signed-off-by: George G. D

Re: [PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks

2019-09-16 Thread David Miller
From: Jose Abreu Date: Fri, 13 Sep 2019 11:50:32 +0200 > We need to hold rnl lock in suspend and resume callbacks because phylink > requires it. Otherwise we will get a WARN() in suspend and resume. > > Also, move phylink start and stop callbacks to inside device's internal > lock so that we pre

[PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks

2019-09-13 Thread Jose Abreu
We need to hold rnl lock in suspend and resume callbacks because phylink requires it. Otherwise we will get a WARN() in suspend and resume. Also, move phylink start and stop callbacks to inside device's internal lock so that we prevent concurrent HW accesses. Fixes: 74371272f97f ("net: stmmac: Co

Re: [PATCH v2 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-09 Thread Doug Anderson
Hi, On Sun, Sep 8, 2019 at 3:12 AM Ulf Hansson wrote: > > System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using > MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile > behaviour. Some problems have been taken care of so far, but more issu

[PATCH v2 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-08 Thread Ulf Hansson
System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile behaviour. Some problems have been taken care of so far, but more issues remains. For example, calling the ->ack_sdio_irq() callback to let h

Re: [PATCH 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-06 Thread Ulf Hansson
On Fri, 6 Sep 2019 at 01:48, Doug Anderson wrote: > > Hi, > > On Tue, Sep 3, 2019 at 7:22 AM Ulf Hansson wrote: > > > > System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using > > MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from

Re: [PATCH 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-06 Thread Ulf Hansson
On Thu, 5 Sep 2019 at 20:43, Matthias Kaehlcke wrote: > > On Tue, Sep 03, 2019 at 04:22:04PM +0200, Ulf Hansson wrote: > > System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using > > MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile &

Re: [PATCH 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-05 Thread Doug Anderson
Hi, On Tue, Sep 3, 2019 at 7:22 AM Ulf Hansson wrote: > > System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using > MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile > behaviour. Some problems have been taken care of so far, but more issu

[PATCH v5 4/9] Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation

2019-09-05 Thread Dexuan Cui
The high-level VSC drivers will implement device-specific callbacks. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/hv/vmbus_drv.c | 46 ++ include/linux/hyperv.h | 3 +++ 2 files changed, 49 insertions(+) diff --git a/drivers/hv/

[PATCH v5 6/9] Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation

2019-09-05 Thread Dexuan Cui
Before Linux enters hibernation, it sends the CHANNELMSG_UNLOAD message to the host so all the offers are gone. After hibernation, Linux needs to re-negotiate with the host using the same vmbus protocol version (which was in use before hibernation), and ask the host to re-offer the vmbus devices.

[PATCH v5 2/9] Drivers: hv: vmbus: Suspend/resume the synic for hibernation

2019-09-05 Thread Dexuan Cui
This is needed when we resume the old kernel from the "current" kernel. Note: when hv_synic_suspend() and hv_synic_resume() run, all the non-boot CPUs have been offlined, and interrupts are disabled on CPU0. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/hv/vmbus_drv.c | 46

[PATCH v5 3/3] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-05 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's TSC page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/clocksource/hyperv_timer.c | 25 + 1 file changed, 2

[PATCH v5 1/3] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-05 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's hypercall page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- arch/x86/hyperv/hv_init.c | 33 + 1 file chang

RE: [PATCH v4 01/12] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-05 Thread Dexuan Cui
> From: Sasha Levin > Sent: Thursday, September 5, 2019 8:44 AM > On Tue, Sep 03, 2019 at 12:23:16AM +, Dexuan Cui wrote: > >This is needed for hibernation, e.g. when we resume the old kernel, we need > >to disable the "current" kernel's hypercall page and then resume the old > >kernel's. > >

Re: [PATCH 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-05 Thread Matthias Kaehlcke
On Tue, Sep 03, 2019 at 04:22:04PM +0200, Ulf Hansson wrote: > System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using > MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile > behaviour. Some problems have been taken care of so far, but more issues

Re: [PATCH v4 01/12] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-05 Thread Sasha Levin
On Tue, Sep 03, 2019 at 12:23:16AM +, Dexuan Cui wrote: This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's hypercall page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley Hi Dexuan, When se

[PATCH 4.14 46/57] crypto: ccp - Ignore unconfigured CCP device on suspend/resume

2019-09-04 Thread Greg Kroah-Hartman
From: Gary R Hook commit 5871cd93692c8071fb9358daccb715b5081316ac upstream. If a CCP is unconfigured (e.g. there are no available queues) then there will be no data structures allocated for the device. Thus, we must check for validity of a pointer before trying to access structure members. Fixe

[PATCH 5.2 118/143] crypto: ccp - Ignore unconfigured CCP device on suspend/resume

2019-09-04 Thread Greg Kroah-Hartman
From: Gary R Hook commit 5871cd93692c8071fb9358daccb715b5081316ac upstream. If a CCP is unconfigured (e.g. there are no available queues) then there will be no data structures allocated for the device. Thus, we must check for validity of a pointer before trying to access structure members. Fixe

[PATCH 4.19 79/93] crypto: ccp - Ignore unconfigured CCP device on suspend/resume

2019-09-04 Thread Greg Kroah-Hartman
From: Gary R Hook commit 5871cd93692c8071fb9358daccb715b5081316ac upstream. If a CCP is unconfigured (e.g. there are no available queues) then there will be no data structures allocated for the device. Thus, we must check for validity of a pointer before trying to access structure members. Fixe

[PATCH 4.4 48/77] x86/pm: Introduce quirk framework to save/restore extra MSR registers around suspend/resume

2019-09-04 Thread Greg Kroah-Hartman
_save[] = {MSR_ID0, MSR_ID1, MSR_ID2...}; and the quirk mechanism ensures that, once resumed from suspend, the MSRs indicated by these IDs will be restored to their original, pre-suspend values. Since both 64-bit and 32-bit kernels are affected, this patch covers the common 64/32-bit suspend/resume code

[PATCH 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-03 Thread Ulf Hansson
System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile behaviour. Some problems have been taken care of so far, but more issues remains. For example, calling the ->ack_sdio_irq() callback to let h

[PATCH v4 07/12] Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation

2019-09-02 Thread Dexuan Cui
The high-level VSC drivers will implement device-specific callbacks. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/hv/vmbus_drv.c | 46 ++ include/linux/hyperv.h | 3 +++ 2 files changed, 49 insertions(+) diff --git a/drivers/hv/

[PATCH v4 05/12] Drivers: hv: vmbus: Suspend/resume the synic for hibernation

2019-09-02 Thread Dexuan Cui
This is needed when we resume the old kernel from the "current" kernel. Note: when hv_synic_suspend() and hv_synic_resume() run, all the non-boot CPUs have been offlined, and interrupts are disabled on CPU0. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/hv/vmbus_drv.c | 46

[PATCH v4 03/12] clocksource/drivers: Suspend/resume Hyper-V clocksource for hibernation

2019-09-02 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's TSC page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- drivers/clocksource/hyperv_timer.c | 25 + 1 file changed, 2

[PATCH v4 09/12] Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation

2019-09-02 Thread Dexuan Cui
Before Linux enters hibernation, it sends the CHANNELMSG_UNLOAD message to the host so all the offers are gone. After hibernation, Linux needs to re-negotiate with the host using the same vmbus protocol version (which was in use before hibernation), and ask the host to re-offer the vmbus devices.

[PATCH v4 01/12] x86/hyper-v: Suspend/resume the hypercall page for hibernation

2019-09-02 Thread Dexuan Cui
This is needed for hibernation, e.g. when we resume the old kernel, we need to disable the "current" kernel's hypercall page and then resume the old kernel's. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- arch/x86/hyperv/hv_init.c | 34 ++ 1 file chan

Re: [alsa-devel] [PATCH] ASoC: cs42xx8: Force suspend/resume during system suspend/resume

2019-08-29 Thread Daniel Baluta
On Tue, 2019-08-27 at 18:13 -0400, Shengjiu Wang wrote: > Use force_suspend/resume to make sure clocks are disabled/enabled > accordingly during system suspend/resume. > > Signed-off-by: Dong Aisheng > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta > --- > sou

<    1   2   3   4   5   6   7   8   9   10   >