[patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Mike Frysinger
This updates scripts/hdrschecks.sh by grepping for asm() constructs and rejecting them in favor of __asm__() in exported headers. Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/scripts/hdrcheck.sh b/scripts/hdrcheck.sh index 3159858..33d17cc 100755 --- a/scripts/hdrcheck.sh

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Arnd Bergmann
On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm but the kernel doesn't use -std=c99... The byteorder headers

Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h

2007-06-17 Thread Mike Frysinger
On Sunday 17 June 2007, Arnd Bergmann wrote: On Monday 18 June 2007, Arjan van de Ven wrote: On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: This changes asm() to __asm__() and volatile to __volatile__ so that these headers can be used with gcc's -std=c99. hmm but the kernel

Re: [patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Andrew Morton
On Sun, 17 Jun 2007 18:54:24 -0400 Mike Frysinger [EMAIL PROTECTED] wrote: This updates scripts/hdrschecks.sh by grepping for asm() constructs and rejecting them in favor of __asm__() in exported headers. And does the kernel pass these checks? Which architectures have been tested

Re: [patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Mike Frysinger
On Monday 18 June 2007, Andrew Morton wrote: On Sun, 17 Jun 2007 18:54:24 -0400 Mike Frysinger [EMAIL PROTECTED] wrote: This updates scripts/hdrschecks.sh by grepping for asm() constructs and rejecting them in favor of __asm__() in exported headers. And does the kernel pass these checks

Re: [patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Andrew Morton
in favor of __asm__() in exported headers. And does the kernel pass these checks? nope ... should i audit the arches before this gets merged ? Yes please. I'd rather not break things in this fashion: it causes a storm of emails which I need to redirect to the appropriate maintainers who then take

Re: [patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Mike Frysinger
for asm() constructs and rejecting them in favor of __asm__() in exported headers. And does the kernel pass these checks? nope ... should i audit the arches before this gets merged ? Yes please. I'd rather not break things in this fashion: it causes a storm of emails which I need

Re: [patch] make hdrscheck.sh force __asm__ in exported headers

2007-06-17 Thread Mike Frysinger
On Monday 18 June 2007, Andrew Morton wrote: Also, your changelog sucks: This updates scripts/hdrschecks.sh by grepping for asm() constructs and rejecting them in favor of __asm__() in exported headers. well OK. But for what reason? We can see a lot of pain in this patch but no gain

Re: [Re: __asm__ ]

2001-05-23 Thread David Howells
Okay, "current" is a macro on i386 that expands to "get_current()". This gets the task_struct for the task currently running on the CPU executing the code. It does this by masking out the bottom bits of its kernel stack pointer. For example, assuming that some running process has the following

Re: [Re: __asm__ ]

2001-05-23 Thread =C0=CC=C8=A3
Blesson Paul Wrote: > Thanks for the reply. I am sorry that I misspelled the > line(__asm__()). It is from the get_current() function in > asm-i386/current.h. But I am not clear what is the whole meaning of that > line(__asm__(..)) in get_current(). I am doi

Re: [Re: __asm__ ]

2001-05-23 Thread Blesson Paul
Hi David Thanks for the reply. I am sorry that I misspelled the line(__asm__()). It is from the get_current() function in asm-i386/current.h. But I am not clear what is the whole meaning of that line(__asm__(..)) in get_current(). I am doing a project in Linux related

Re: __asm__

2001-05-23 Thread David Howells
> __asm__("and 1 %%esp.%0; ":"=r" (current) : "0" (~8191UL)); This doesn't look right... Where did you get this from. Taking the one in include/asm-i386/current.h as an example: | __asm__( This signifies a piece of inline assembly that the compiler

__asm__

2001-05-23 Thread Blesson Paul
Hi I am comfronting with a macro __asm__ . What is the meaning of this. I cannot find the definition of this. I need the meaning of this line __asm__("and 1 %%esp.%0; ":"=r" (current) : "0" (~8191UL)); This is defined inside

__asm__

2001-05-23 Thread Blesson Paul
Hi I am comfronting with a macro __asm__ . What is the meaning of this. I cannot find the definition of this. I need the meaning of this line __asm__(and 1 %%esp.%0; :=r (current) : 0 (~8191UL)); This is defined inside the get_current() in current.h

Re: __asm__

2001-05-23 Thread David Howells
__asm__(and 1 %%esp.%0; :=r (current) : 0 (~8191UL)); This doesn't look right... Where did you get this from. Taking the one in include/asm-i386/current.h as an example: | __asm__( This signifies a piece of inline assembly that the compiler must insert into it's output code. The __asm__

Re: [Re: __asm__ ]

2001-05-23 Thread Blesson Paul
Hi David Thanks for the reply. I am sorry that I misspelled the line(__asm__()). It is from the get_current() function in asm-i386/current.h. But I am not clear what is the whole meaning of that line(__asm__(..)) in get_current(). I am doing a project in Linux related

Re: [Re: __asm__ ]

2001-05-23 Thread =C0=CC=C8=A3
Blesson Paul Wrote: Thanks for the reply. I am sorry that I misspelled the line(__asm__()). It is from the get_current() function in asm-i386/current.h. But I am not clear what is the whole meaning of that line(__asm__(..)) in get_current(). I am doing a project

Re: [Re: __asm__ ]

2001-05-23 Thread David Howells
Okay, current is a macro on i386 that expands to get_current(). This gets the task_struct for the task currently running on the CPU executing the code. It does this by masking out the bottom bits of its kernel stack pointer. For example, assuming that some running process has the following

<    1   2