Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Andrew Morton
On Tue, 26 Feb 2008 19:16:11 +0100 Pavel Machek <[EMAIL PROTECTED]> wrote: > On Tue 2008-02-26 13:10:01, Dave Jones wrote: > > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > > > if by 'custom' you mean the solution everyone agreed to work > > > > toward at the power mana

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Dave Jones
On Tue, Feb 26, 2008 at 07:16:11PM +0100, Pavel Machek wrote: > On Tue 2008-02-26 13:10:01, Dave Jones wrote: > > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > > > if by 'custom' you mean the solution everyone agreed to work > > > > toward at the power management su

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Pavel Machek
On Tue 2008-02-26 13:10:01, Dave Jones wrote: > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > if by 'custom' you mean the solution everyone agreed to work > > > toward at the power management summit several years ago > > > (hal/pm-utils) then, yes. > > > > I must hav

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Dave Jones
On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > if by 'custom' you mean the solution everyone agreed to work > > toward at the power management summit several years ago > > (hal/pm-utils) then, yes. > > I must have been on different summit... I believe it is bad to tie >

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Pavel Machek
On Tue 2008-02-26 12:46:13, Dave Jones wrote: > On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: > > Hi! > > > > Andrew is trying to get s2ram to work on Fedora: > > > > > > > Please try s2ram, there's good chance it will just work. > > > > > > > > configure: error: Required

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Dave Jones
On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: > Hi! > > Andrew is trying to get s2ram to work on Fedora: > > > > > Please try s2ram, there's good chance it will just work. > > > > > > configure: error: Required libx86 was not found > > > > apt-get install libx86-dev? >

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Pavel Machek
Hi! Andrew is trying to get s2ram to work on Fedora: > > > Please try s2ram, there's good chance it will just work. > > > > configure: error: Required libx86 was not found > > apt-get install libx86-dev? > > Alternatively, can you post dmidecode? Thinkpads usually work with > acpi_sleep=s3_bio

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Michael S. Tsirkin
On Tue, Feb 26, 2008 at 12:53 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 26 Feb 2008 00:48:12 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton > > <[EMAIL PROTECTED]> wrote: > > > On Tue, 26 Feb 2008 00:36:54 +0200 "Mich

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Pavel Machek
Hi! > > > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] > > > > > > And earlier - I think 2.6.23 does it as well. > > > > But that one at least resumes fine, does it not? > > Nope, the resume-after-five-seconds and black-screen-after-resume have > always been there (I've only had t

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Andrew Morton
On Tue, 26 Feb 2008 00:48:12 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > > wrote: > > > > > > Hmm, mystery partly solved...

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Michael S. Tsirkin
On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > > Hmm, mystery partly solved... as you guessed it, this piece of code > > > was not in my tree. > > > > > > (still, how can

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Andrew Morton
On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > > Hmm, mystery partly solved... as you guessed it, this piece of code > > was not in my tree. > > > > (still, how can this cause autoresume after 5 seconds is a mystery to > > me). > > > > > >

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Michael S. Tsirkin
On Tue, Feb 26, 2008 at 12:20 AM, Pavel Machek <[EMAIL PROTECTED]> wrote: > > Hi! > > > > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > > > > > Author: Pavel Machek <[EMAIL PROTECTED]> > > > > > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > > > > > > > > > power_st

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Pavel Machek
On Mon 2008-02-25 16:32:38, Jeff Garzik wrote: > Pavel Machek wrote: >>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 >>> Author: Pavel Machek <[EMAIL PROTECTED]> >>> Date: Thu Feb 21 13:56:55 2008 +0100 >>> >>> power_state: get rid of write-only variable in SATA >> >> This is pretty unlik

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Pavel Machek
Hi! > > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > > > > Author: Pavel Machek <[EMAIL PROTECTED]> > > > > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > > > > > > > power_state: get rid of write-only variable in SATA > > > > > > > > This is pretty unlikely to be i

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Michael S. Tsirkin
On Mon, Feb 25, 2008 at 11:50 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > > > Author: Pavel Machek <[EMAIL PROTECTED]> > > > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > > > > > power_state: get rid of write-onl

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Pavel Machek
Hi! > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > > Author: Pavel Machek <[EMAIL PROTECTED]> > > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > > > power_state: get rid of write-only variable in SATA > > > > This is pretty unlikely to be it. Can you double check that this p

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Jeff Garzik
Pavel Machek wrote: commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek <[EMAIL PROTECTED]> Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks somet

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Michael S. Tsirkin
On Mon, Feb 25, 2008 at 11:26 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > > On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > > > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > > > <[EMAIL PROTECTED]> wrote: > > > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin"

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Pavel Machek
Hi! > On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > > <[EMAIL PROTECTED]> wrote: > > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL > > > PROTECTED]> wrote: > > > > > > > On my T61p, 2.6.25-rc2 seems to get acpi

broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-25 Thread Rafael J. Wysocki
On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > > wrote: > > > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypres