Re: [linux-pm] Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-03 Thread Pavel Machek
Hi! > >> > Sorry for being late responding to this, but I'd say this is a > >> prime > example for typedef's considered evil (see Greg's OLS talk > >> ;). > >> > > >> > It would be a lot cleaner if it was made a struct and then > >> passing a > struct pointer as the argument instead of passing

Re: [linux-pm] Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-03 Thread Jes Sorensen
> "Pavel" == Pavel Machek <[EMAIL PROTECTED]> writes: >> > Sorry for being late responding to this, but I'd say this is a >> prime > example for typedef's considered evil (see Greg's OLS talk >> ;). >> > >> > It would be a lot cleaner if it was made a struct and then >> passing a > struct

Re: [linux-pm] Re: driver model u32 - pm_message_t conversion: help needed

2005-02-03 Thread Jes Sorensen
Pavel == Pavel Machek [EMAIL PROTECTED] writes: Sorry for being late responding to this, but I'd say this is a prime example for typedef's considered evil (see Greg's OLS talk ;). It would be a lot cleaner if it was made a struct and then passing a struct pointer as the argument

Re: [linux-pm] Re: driver model u32 - pm_message_t conversion: help needed

2005-02-03 Thread Pavel Machek
Hi! Sorry for being late responding to this, but I'd say this is a prime example for typedef's considered evil (see Greg's OLS talk ;). It would be a lot cleaner if it was made a struct and then passing a struct pointer as the argument instead of passing the struct by value

Re: [linux-pm] Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-02 Thread Pavel Machek
Hi! > > Pavel> Hi! Two Long time ago, BenH said that making patches is easy, > > Pavel> so I hope to get his help now... And will probably need more. > > > > Pavel> Suspend routines change, slowly. > > > > Pavel> - int (*suspend)(struct device * dev, u32 state); + int > > Pavel>

Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-02 Thread Pavel Machek
Hi! > Pavel> Hi! Two Long time ago, BenH said that making patches is easy, > Pavel> so I hope to get his help now... And will probably need more. > > Pavel> Suspend routines change, slowly. > > Pavel> - int (*suspend)(struct device * dev, u32 state); + int > Pavel> (*suspend)(struct device *

Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-02 Thread Jes Sorensen
> "Pavel" == Pavel Machek <[EMAIL PROTECTED]> writes: Pavel> Hi! Two Long time ago, BenH said that making patches is easy, Pavel> so I hope to get his help now... And will probably need more. Pavel> Suspend routines change, slowly. Pavel> - int (*suspend)(struct device * dev, u32 state); +

Re: driver model u32 - pm_message_t conversion: help needed

2005-02-02 Thread Jes Sorensen
Pavel == Pavel Machek [EMAIL PROTECTED] writes: Pavel Hi! Two Long time ago, BenH said that making patches is easy, Pavel so I hope to get his help now... And will probably need more. Pavel Suspend routines change, slowly. Pavel - int (*suspend)(struct device * dev, u32 state); + int Pavel

Re: driver model u32 - pm_message_t conversion: help needed

2005-02-02 Thread Pavel Machek
Hi! Pavel Hi! Two Long time ago, BenH said that making patches is easy, Pavel so I hope to get his help now... And will probably need more. Pavel Suspend routines change, slowly. Pavel - int (*suspend)(struct device * dev, u32 state); + int Pavel (*suspend)(struct device * dev,

Re: [linux-pm] Re: driver model u32 - pm_message_t conversion: help needed

2005-02-02 Thread Pavel Machek
Hi! Pavel Hi! Two Long time ago, BenH said that making patches is easy, Pavel so I hope to get his help now... And will probably need more. Pavel Suspend routines change, slowly. Pavel - int (*suspend)(struct device * dev, u32 state); + int Pavel (*suspend)(struct device * dev,

Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-01 Thread Pavel Machek
Hi! > >Now, if you want to help, just convert some drivers... To quickly > >break compilation in case of bad types, following patch can be used > >(against 2.6.11-rc2-mm1), it actually switches pm_message_t to > >typedef. > > > >I'm looking forward to the patches, (please help), > > I just had a

Re: driver model u32 -> pm_message_t conversion: help needed

2005-02-01 Thread Daniel Drake
Hi Pavel, Pavel Machek wrote: Now, if you want to help, just convert some drivers... To quickly break compilation in case of bad types, following patch can be used (against 2.6.11-rc2-mm1), it actually switches pm_message_t to typedef. I'm looking forward to the patches, (please help), I just had

Re: driver model u32 - pm_message_t conversion: help needed

2005-02-01 Thread Daniel Drake
Hi Pavel, Pavel Machek wrote: Now, if you want to help, just convert some drivers... To quickly break compilation in case of bad types, following patch can be used (against 2.6.11-rc2-mm1), it actually switches pm_message_t to typedef. I'm looking forward to the patches, (please help), I just had

Re: driver model u32 - pm_message_t conversion: help needed

2005-02-01 Thread Pavel Machek
Hi! Now, if you want to help, just convert some drivers... To quickly break compilation in case of bad types, following patch can be used (against 2.6.11-rc2-mm1), it actually switches pm_message_t to typedef. I'm looking forward to the patches, (please help), I just had a look at

Re: driver model u32 -> pm_message_t conversion: help needed

2005-01-25 Thread Benjamin Herrenschmidt
On Tue, 2005-01-25 at 20:47 +0100, Pavel Machek wrote: > Hi! > > Two Long time ago, BenH said that making patches is easy, so I hope to > get his help now... And will probably need more. I will. I'm still a bit dealing with backlog of stuffs after my long vacations, but I will asap. Ben. - To

driver model u32 -> pm_message_t conversion: help needed

2005-01-25 Thread Pavel Machek
Hi! Two Long time ago, BenH said that making patches is easy, so I hope to get his help now... And will probably need more. Suspend routines change, slowly. - int (*suspend)(struct device * dev, u32 state); + int (*suspend)(struct device * dev, pm_message_t

driver model u32 - pm_message_t conversion: help needed

2005-01-25 Thread Pavel Machek
Hi! Two Long time ago, BenH said that making patches is easy, so I hope to get his help now... And will probably need more. Suspend routines change, slowly. - int (*suspend)(struct device * dev, u32 state); + int (*suspend)(struct device * dev, pm_message_t

Re: driver model u32 - pm_message_t conversion: help needed

2005-01-25 Thread Benjamin Herrenschmidt
On Tue, 2005-01-25 at 20:47 +0100, Pavel Machek wrote: Hi! Two Long time ago, BenH said that making patches is easy, so I hope to get his help now... And will probably need more. I will. I'm still a bit dealing with backlog of stuffs after my long vacations, but I will asap. Ben. - To