Re: firmware_class warnings on resume

2015-12-21 Thread Andy Lutomirski
On Mon, Dec 21, 2015 at 9:54 AM, Laura Abbott wrote: > On 12/20/2015 04:20 AM, Andy Lutomirski wrote: >> >> I hit this warning fairly frequently when resuming 4.4-rc5: >> >> ret = usermodehelper_read_trylock(); >> if (WARN_ON(ret)) { >> dev_err(device, "firmware: %s

Re: firmware_class warnings on resume

2015-12-21 Thread Laura Abbott
On 12/20/2015 04:20 AM, Andy Lutomirski wrote: I hit this warning fairly frequently when resuming 4.4-rc5: ret = usermodehelper_read_trylock(); if (WARN_ON(ret)) { dev_err(device, "firmware: %s will not be loaded\n", name); goto out;

firmware_class warnings on resume

2015-12-20 Thread Andy Lutomirski
I hit this warning fairly frequently when resuming 4.4-rc5: ret = usermodehelper_read_trylock(); if (WARN_ON(ret)) { dev_err(device, "firmware: %s will not be loaded\n", name); goto out; } It seems like it could be improved in two wa