On Fri, Dec 11, 2020 at 10:08:54AM +0100, Markus Elfring wrote:
> > This makes it hard to review any patches or follow discussion...
>
> You shared also special software development opinions about extra variable
> initialisations occasionally, didn't you?
I generally put everything at the top of
On Sat, 2020-12-12 at 14:17 +0100, Alexandre Belloni wrote:
> On 12/12/2020 01:16:39-0800, Joe Perches wrote:
> > In this case Alexandre it seems true, but in the generic case
> > it may be false. It may depend on stack size and location.
> >
> > For instance, with large structs declared either a
On 12/12/2020 01:16:39-0800, Joe Perches wrote:
> On Fri, 2020-12-11 at 09:03 +0100, Alexandre Belloni wrote:
> > On 11/12/2020 07:34:41+0100, Markus Elfring wrote:
> > > > > How do you think about a patch like “staging: speakup: remove
> > > > > redundant initialization
> > > > > of pointer p_key
On Fri, 2020-12-11 at 09:03 +0100, Alexandre Belloni wrote:
> On 11/12/2020 07:34:41+0100, Markus Elfring wrote:
> > > > How do you think about a patch like “staging: speakup: remove redundant
> > > > initialization
> > > > of pointer p_key” for comparison?
> > > > https://lore.kernel.org/patchwor
Markus was banned from vger at the end of July after ignoring repeated
warnings. This makes it hard to review any patches or follow
discussion...
regards,
dan carpenter
On 11/12/2020 07:34:41+0100, Markus Elfring wrote:
> >> How do you think about a patch like “staging: speakup: remove redundant
> >> initialization
> >> of pointer p_key” for comparison?
> >> https://lore.kernel.org/patchwork/patch/1199128/
> >> https://lore.kernel.org/driverdev-devel/202002231539
On 10/12/2020 18:23:05+0100, Markus Elfring wrote:
> >> Can the extra null pointer initialisation trigger a source code analysis
> >> warning
> >> like “Addresses-Coverity: ("Unused value")” for this function
> >> implementation?
> >>
> >
> > Did you check, does it? It doesn't.
> >
> > Are you wa
On 10/12/2020 17:35:31+0100, Markus Elfring wrote:
> >> A local variable was used only within an if branch.
> >> Thus move the definition for the variable “slot” into the corresponding
> >> code block.
> >>
> >
> > What is the improvement here?
>
> A possible refactoring.
> https://refactoring.com
Hello,
On 10/12/2020 16:01:44+0100, Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 10 Dec 2020 15:56:13 +0100
>
> A local variable was used only within an if branch.
> Thus move the definition for the variable “slot” into the corresponding
> code block.
>
What is the improvement her
9 matches
Mail list logo
