Re: my first janitorial

2007-04-01 Thread Jan Engelhardt
On Apr 1 2007 08:17, Willy Tarreau wrote: > > - your patch was cut and cannot apply to anything. A proper patch starts > with line beginning with "---" line, followed by a line with "+++", > both indicating the file your patch is supposed to apply to. Make your > patch with one

Re: my first janitorial

2007-04-01 Thread Jiri Slaby
Alan Cox napsal(a): > On Sat, 31 Mar 2007 22:24:12 -0700 > "Pedram M" <[EMAIL PROTECTED]> wrote: > >> How about this one? Am I doing it right now? >> If not, please try to explain more to me what I am >> doing wrong. > > You need to hold a reference to the PCI device for the entire duration it >

Re: my first janitorial

2007-04-01 Thread Alan Cox
On Sat, 31 Mar 2007 22:24:12 -0700 "Pedram M" <[EMAIL PROTECTED]> wrote: > How about this one? Am I doing it right now? > If not, please try to explain more to me what I am > doing wrong. You need to hold a reference to the PCI device for the entire duration it is used. I think you actually also

Re: my first janitorial

2007-04-01 Thread Alan Cox
On Sat, 31 Mar 2007 22:24:12 -0700 Pedram M [EMAIL PROTECTED] wrote: How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. You need to hold a reference to the PCI device for the entire duration it is used. I think you actually also need

Re: my first janitorial

2007-04-01 Thread Jiri Slaby
Alan Cox napsal(a): On Sat, 31 Mar 2007 22:24:12 -0700 Pedram M [EMAIL PROTECTED] wrote: How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. You need to hold a reference to the PCI device for the entire duration it is used. I

Re: my first janitorial

2007-04-01 Thread Jan Engelhardt
On Apr 1 2007 08:17, Willy Tarreau wrote: - your patch was cut and cannot apply to anything. A proper patch starts with line beginning with --- line, followed by a line with +++, both indicating the file your patch is supposed to apply to. Make your patch with one level

Re: [KJ] my first janitorial

2007-03-31 Thread Jaco Kroon
Pedram M wrote: How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. You need a changelog entry (or explanation of what you're doing). You need a signed-off-by line and your patch needs to apply to the root of the kernel tree with -p1,

Re: my first janitorial

2007-03-31 Thread Willy Tarreau
Hi, On Sat, Mar 31, 2007 at 10:24:12PM -0700, Pedram M wrote: > How about this one? Am I doing it right now? > If not, please try to explain more to me what I am > doing wrong. You have made several mistakes : - you must select an appropriate subject for your mail. Nobody cares that it is

Re: my first janitorial

2007-03-31 Thread Pedram M
How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. @@ -4760,7 +4760,7 @@ for (i = 0; i < NR_CARDS; i++) { /* look for a Cyclades card by vendor and device id */ while ((device_id =

Re: my first janitorial

2007-03-31 Thread Pedram M
How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. @@ -4760,7 +4760,7 @@ for (i = 0; i NR_CARDS; i++) { /* look for a Cyclades card by vendor and device id */ while ((device_id =

Re: my first janitorial

2007-03-31 Thread Willy Tarreau
Hi, On Sat, Mar 31, 2007 at 10:24:12PM -0700, Pedram M wrote: How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. You have made several mistakes : - you must select an appropriate subject for your mail. Nobody cares that it is

Re: [KJ] my first janitorial

2007-03-31 Thread Jaco Kroon
Pedram M wrote: How about this one? Am I doing it right now? If not, please try to explain more to me what I am doing wrong. You need a changelog entry (or explanation of what you're doing). You need a signed-off-by line and your patch needs to apply to the root of the kernel tree with -p1,